[PM-11437] 1Password 1pux importer updates and fixes #10778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new field state contains either 'active' or 'archived' Adjust all the test files to have the new field Add unit test to verify skipping archived items on import Fix importer
No mapping currently necessary
Removing it from the 1pux-importer-types Updating all the test files
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10778 +/- ##
==========================================
- Coverage 33.23% 33.22% -0.01%
==========================================
Files 2730 2730
Lines 85257 85257
Branches 16221 16221
==========================================
- Hits 28333 28326 -7
- Misses 54668 54675 +7
Partials 2256 2256 ☔ View full report in Codecov by Sentry. |
audreyality
approved these changes
Aug 29, 2024
| @@ -153,6 +153,8 @@ export interface Overview { | |||
| pbe?: number | null; | |||
| pgrng?: boolean | null; | |||
| tags?: string[] | null; | |||
| icons?: string | null; | |||
| watchtowerExclusions?: string | null; | |||
There was a problem hiding this comment.
🌱 We might want to consider whether this data should be retained for use by our reports.
There was a problem hiding this comment.
Great idea. Yes, we'll need to see what kind of values are stored there and see if we could use any of them
djsmith85
added a commit
that referenced
this pull request
Oct 7, 2024
* Replaced field trashed with state The new field state contains either 'active' or 'archived' Adjust all the test files to have the new field Add unit test to verify skipping archived items on import Fix importer * Add addtional fields to 1pux importer types No mapping currently necessary * Field indexAtSource was deprecated Removing it from the 1pux-importer-types Updating all the test files * Removed remaining instances of indexAtSource * Fixed a leftover instance of trashed -> state --------- Co-authored-by: Daniel James Smith <[email protected]> (cherry picked from commit e47415f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11437
📔 Objective
Looking at a recent export of 1Password's 1Pux, there seems to be some changes within the format.
This aims to add any missing fields to the types but also fix any import issues.
The majority of the changes are updating the test-files
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes