Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Design System: Update ngx-toastr to v19 #10594

Merged
merged 9 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/components/src/toast/toast.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@
(click)="this.onClose.emit()"
></button>
</div>
<div class="tw-h-1 tw-w-full tw-bg-text-main/30" [style.width]="progressWidth + '%'"></div>
<div class="tw-h-1 tw-w-full tw-bg-text-main/30" [style.width]="progressWidth() + '%'"></div>
</div>
5 changes: 3 additions & 2 deletions libs/components/src/toast/toast.component.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import { Component, EventEmitter, Input, Output } from "@angular/core";
import { Component, EventEmitter, Input, Output, signal } from "@angular/core";

Check warning on line 3 in libs/components/src/toast/toast.component.ts

View check run for this annotation

Codecov / codecov/patch

libs/components/src/toast/toast.component.ts#L3

Added line #L3 was not covered by tests
import { Toast } from "ngx-toastr";

import { IconButtonModule } from "../icon-button";
import { SharedModule } from "../shared";
Expand Down Expand Up @@ -50,7 +51,7 @@
/**
* The percent width of the progress bar, from 0-100
**/
@Input() progressWidth = 0;
@Input() progressWidth: Toast["width"] = signal(0);

Check warning on line 54 in libs/components/src/toast/toast.component.ts

View check run for this annotation

Codecov / codecov/patch

libs/components/src/toast/toast.component.ts#L54

Added line #L54 was not covered by tests

/** Emits when the user presses the close button */
@Output() onClose = new EventEmitter<void>();
Expand Down
4 changes: 2 additions & 2 deletions libs/components/src/toast/toast.stories.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import { CommonModule } from "@angular/common";
import { Component, Input } from "@angular/core";
import { Component, Input, signal } from "@angular/core";

Check warning on line 4 in libs/components/src/toast/toast.stories.ts

View check run for this annotation

Codecov / codecov/patch

libs/components/src/toast/toast.stories.ts#L4

Added line #L4 was not covered by tests
import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
import { action } from "@storybook/addon-actions";
import { Meta, StoryObj, applicationConfig, moduleMetadata } from "@storybook/angular";
Expand Down Expand Up @@ -58,7 +58,7 @@
args: {
onClose: action("emit onClose"),
variant: "info",
progressWidth: 50,
progressWidth: signal(50),
title: "",
message: "Hello Bitwarden!",
},
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
"lunr": "2.3.9",
"multer": "1.4.5-lts.1",
"ngx-infinite-scroll": "17.0.1",
"ngx-toastr": "18.0.0",
"ngx-toastr": "19.0.0",
"node-fetch": "2.6.12",
"node-forge": "1.3.1",
"nord": "0.2.1",
Expand Down
Loading