[PM-10395] Add new item type ssh key #10360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## feature/ssh-keys #10360 +/- ##
====================================================
+ Coverage 32.92% 32.93% +0.01%
====================================================
Files 2671 2677 +6
Lines 81785 81907 +122
Branches 15418 15435 +17
====================================================
+ Hits 26928 26977 +49
- Misses 52774 52841 +67
- Partials 2083 2089 +6 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 2, 2024
chadmiller
reviewed
Aug 11, 2024
apps/browser/src/vault/popup/components/vault/add-edit.component.html
Outdated
Show resolved
Hide resolved
apps/browser/src/vault/popup/components/vault/view.component.html
Outdated
Show resolved
Hide resolved
apps/browser/src/vault/popup/components/vault/view.component.html
Outdated
Show resolved
Hide resolved
quexten
force-pushed
the
auth/pm-10395/ssh-keys-item-type
branch
from
e1debc0 to
22fe2da
Compare
quexten
force-pushed
the
auth/pm-10395/ssh-keys-item-type
branch
from
a0c9686 to
4ee2944
Compare
quexten
force-pushed
the
auth/pm-10395/ssh-keys-item-type
branch
from
4ee2944 to
99f10b1
Compare
merissaacosta
requested review from
gbubemismith
and removed request for
LRNcardozoWDF
This was referenced Aug 26, 2024
gbubemismith
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Thank you for your work on this, @quexten. I have noted a few areas that need adjustment, but overall this looks really good 🚀
libs/vault/src/cipher-view/sshkey-sections/sshkey-view.component.html
Outdated
Show resolved
Hide resolved
libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.html
Outdated
Show resolved
Hide resolved
quexten
force-pushed
the
auth/pm-10395/ssh-keys-item-type
branch
from
1f6b02f to
cc36ebb
Compare
quexten
requested review from
gbubemismith
and removed request for
a team and
dani-garcia
gbubemismith
approved these changes
Aug 30, 2024
|
Merging to the feature branch; QA testing will be done on the feature-branch. |
Merged
quexten
added a commit
that referenced
this pull request
Nov 8, 2024
* [PM-10395] Add new item type ssh key (#10360) * Implement ssh-key cipher type * Fix linting * Fix edit and view components for ssh-keys on desktop * Fix tests * Remove ssh key type references * Remove add ssh key option * Fix typo * Add tests * [PM-10399] Add ssh key import export for bitwarden json (#10529) * Add ssh key import export for bitwarden json * Remove key type from ssh key export * [PM-10406] Add privatekey publickey and fingerprint to both add-edit and view co… (#11046) * Add privatekey publickey and fingerprint to both add-edit and view components * Remove wrong a11y title * Fix testid * [PM-10098] SSH Agent & SSH Key creation for Bitwarden Desktop (#10293) * Add ssh agent, generator & import * Move ssh agent code to bitwarden-russh crate * Remove generator component * Cleanup * Cleanup * Remove left over sshGenerator reference * Cleanup * Add documentation to sshkeyimportstatus * Fix outdated variable name * Update apps/desktop/src/platform/preload.ts Co-authored-by: Andreas Coroiu <[email protected]> * Rename renderersshagent * Rename MainSshAgentService * Improve clarity of 'id' variables being used * Improve clarity of 'id' variables being used * Update apps/desktop/src/vault/app/vault/add-edit.component.html Co-authored-by: Andreas Coroiu <[email protected]> * Fix outdated cipher/messageid names * Rename SSH to Ssh * Make agent syncing more reactive * Move constants to top of class * Make sshkey cipher filtering clearer * Add stricter equality check on ssh key unlock * Fix build and messages * Fix incorrect featureflag name * Replace anonymous async function with switchmap pipe * Fix build * Update apps/desktop/desktop_native/napi/src/lib.rs Co-authored-by: Andreas Coroiu <[email protected]> * Revert incorrectly renamed 'Ssh' usages to SSH * Run cargo fmt * Clean up ssh agent sock path logic * Cleanup and split to platform specific files * Small cleanup * Pull out generator and importer into core * Rename renderersshagentservice to sshagentservice * Rename cipheruuid to cipher_id * Drop ssh dependencies from napi crate * Clean up windows build * Small cleanup * Small cleanup * Cleanup * Add rxjs pipeline for agent services * [PM-12555] Pkcs8 sshkey import & general ssh key import tests (#11048) * Add pkcs8 import and tests * Add key type unsupported error * Remove unsupported formats * Remove code for unsupported formats * Fix encrypted pkcs8 import * Add ed25519 pkcs8 unencrypted test file * SSH agent rxjs tweaks (#11148) * feat: rewrite sshagent.signrequest as purely observable * feat: fail the request when unlock times out * chore: clean up, add some clarifying comments * chore: remove unused dependency * fix: result `undefined` crashing in NAPI -> Rust * Allow concurrent SSH requests in rust * Remove unwraps * Cleanup and add init service init call * Fix windows * Fix timeout behavior on locked vault --------- Co-authored-by: Andreas Coroiu <[email protected]> * Fix libc dependency being duplicated * fix SSH casing (#11840) * Move ssh agent behind feature flag (#11841) * Move ssh agent behind feature flag * Add separate flag for ssh agent * [PM-14215] fix unsupported key type error message (#11788) * Fix error message for import of unsupported ssh keys * Use triple equals in add-edit component for ssh keys --------- Co-authored-by: Andreas Coroiu <[email protected]> Co-authored-by: aj-bw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Server: bitwarden/server#4575
Add Item Type: #10360
Add SSH Agent: #10293
Add Import/Export: #10529
Jira: https://bitwarden.atlassian.net/browse/PM-10395
📔 Objective
Add the new SSH key item type, consisting of private key, and derived fingerprint and public key. We are not generating these on the fly since we do not have the sdk available on all clients.
Note
This will be merged into a feature branch. This PR does not support key generation or import, thus testing will be done in the feature branch.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes