adress feedback

bitwarden · Dec 10, 2024 · 9c2c03e · 9c2c03e
1 parent 97f9692
commit 9c2c03e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts b/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
@@ -171,9 +171,13 @@ export class InlineMenuFieldQualificationService
       return this.isFieldForLoginFormFallback(field);
     }
 
-    const isTotpField = this.isTotpField(field);
+    /**
+     * Autofill does not fill password type totp input fields
+     */
     if (this.inlineMenuTotpFeatureFlag) {
-      if (isTotpField) {
+      const isTotpField = this.isTotpField(field);
+      const passwordType = field.type === "password";
+      if (isTotpField && !passwordType) {
         return true;
       }
     }

diff --git a/apps/browser/src/background/runtime.background.ts b/apps/browser/src/background/runtime.background.ts
@@ -71,7 +71,7 @@ export default class RuntimeBackground {
         "biometricUnlockAvailable",
         "getUseTreeWalkerApiForPageDetailsCollectionFeatureFlag",
         "getInlineMenuFieldQualificationFeatureFlag",
-        "getInlineMenuTotpFlag",
+        "getInlineMenuTotpFeatureFlag",
       ];
 
       if (messagesWithResponse.includes(msg.command)) {