[PM-7280] Check command args for disabled updater (#8613)

* dont autoupdate on older OS and with args * remove os release checking * use dashes
bitwarden · Apr 11, 2024 · 5939241 · 5939241
1 parent 787ad64
commit 5939241
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/apps/desktop/src/main/updater.main.ts b/apps/desktop/src/main/updater.main.ts
@@ -27,8 +27,7 @@ export class UpdaterMain {
       process.platform === "win32" && !isWindowsStore() && !isWindowsPortable();
     const macCanUpdate = process.platform === "darwin" && !isMacAppStore();
     this.canUpdate =
-      process.env.ELECTRON_NO_UPDATER !== "1" &&
-      (linuxCanUpdate || windowsCanUpdate || macCanUpdate);
+      !this.userDisabledUpdates() && (linuxCanUpdate || windowsCanUpdate || macCanUpdate);
   }
 
   async init() {
@@ -144,4 +143,13 @@ export class UpdaterMain {
     autoUpdater.autoDownload = true;
     this.doingUpdateCheck = false;
   }
+
+  private userDisabledUpdates(): boolean {
+    for (const arg of process.argv) {
+      if (arg != null && arg.toUpperCase().indexOf("--ELECTRON_NO_UPDATER=1") > -1) {
+        return true;
+      }
+    }
+    return process.env.ELECTRON_NO_UPDATER === "1";
+  }
 }