[PM-6328] Checkmarx - Resolve warnings (#7941)

bitwarden · Feb 15, 2024 · 02dde0c · 02dde0c
1 parent c8c1ed4
commit 02dde0c
Show file tree

Hide file tree

Showing 49 changed files with 101 additions and 85 deletions.
diff --git a/apps/browser/src/auth/popup/register.component.html b/apps/browser/src/auth/popup/register.component.html
@@ -132,11 +132,11 @@ <h1 class="center">
           <input type="checkbox" id="acceptPolicies" formControlName="acceptPolicies" />
           <label for="acceptPolicies">
             {{ "acceptPolicies" | i18n }}<br />
-            <a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{
+            <a href="https://bitwarden.com/terms/" target="_blank" rel="noreferrer">{{
               "termsOfService" | i18n
             }}</a
             >,
-            <a href="https://bitwarden.com/privacy/" target="_blank" rel="noopener">{{
+            <a href="https://bitwarden.com/privacy/" target="_blank" rel="noreferrer">{{
               "privacyPolicy" | i18n
             }}</a>
           </label>

diff --git a/apps/browser/src/autofill/notification/bar.html b/apps/browser/src/autofill/notification/bar.html
@@ -8,7 +8,7 @@
   <body>
     <div class="outer-wrapper">
       <div class="logo">
-        <a href="https://vault.bitwarden.com" target="_blank" id="logo-link">
+        <a href="https://vault.bitwarden.com" target="_blank" id="logo-link" rel="noreferrer">
           <img id="logo" alt="Bitwarden" />
         </a>
       </div>

diff --git a/apps/browser/src/autofill/popup/settings/autofill.component.html b/apps/browser/src/autofill/popup/settings/autofill.component.html
@@ -67,7 +67,7 @@ <h1 class="center">
         [attr.href]="disablePasswordManagerLink"
         (click)="openDisablePasswordManagerLink($event)"
         target="_blank"
-        rel="noopener noreferrer"
+        rel="noreferrer"
       >
         {{ "turnOffBrowserBuiltInPasswordManagerSettingsLink" | i18n }}
       </a>
@@ -90,11 +90,7 @@ <h1 class="center">
       {{ "enableAutoFillOnPageLoadDesc" | i18n }}
       <b>{{ "warning" | i18n }}</b
       >: {{ "experimentalFeature" | i18n }}
-      <a
-        href="https://bitwarden.com/help/auto-fill-browser/"
-        target="_blank"
-        rel="noopener noreferrer"
-      >
+      <a href="https://bitwarden.com/help/auto-fill-browser/" target="_blank" rel="noreferrer">
         {{ "learnMoreAboutAutofill" | i18n }}.
         <i
           [attr.aria-label]="'opensInANewWindow' | i18n"

diff --git a/apps/browser/src/popup/components/private-mode-warning.component.html b/apps/browser/src/popup/components/private-mode-warning.component.html
@@ -1,6 +1,6 @@
 <app-callout class="app-private-mode-warning" type="warning" *ngIf="showWarning">
   {{ "privateModeWarning" | i18n }}
-  <a href="https://bitwarden.com/help/article/private-mode/" target="_blank" rel="noopener">{{
+  <a href="https://bitwarden.com/help/article/private-mode/" target="_blank" rel="noreferrer">{{
     "learnMore" | i18n
   }}</a>
 </app-callout>
diff --git a/apps/browser/src/tools/popup/generator/generator.component.html b/apps/browser/src/tools/popup/generator/generator.component.html
@@ -309,7 +309,7 @@ <h2 class="box-header">
             <a
               href="https://bitwarden.com/help/generator/#username-types"
               target="_blank"
-              rel="noopener"
+              rel="noreferrer"
               appA11yTitle="{{ 'learnMore' | i18n }}"
             >
               <i class="bwi bwi-question-circle" aria-hidden="true"></i>

diff --git a/apps/browser/src/vault/popup/components/vault/add-edit.component.html b/apps/browser/src/vault/popup/components/vault/add-edit.component.html
@@ -657,7 +657,7 @@ <h2 class="box-header">
             {{ "passwordPrompt" | i18n }}
             <a
               target="_blank"
-              rel="noopener"
+              rel="noreferrer"
               appA11yTitle="{{ 'learnMore' | i18n }}"
               href="https://bitwarden.com/help/managing-items/#protect-individual-items"
             >

diff --git a/apps/desktop/src/auth/register.component.html b/apps/desktop/src/auth/register.component.html
@@ -129,11 +129,11 @@ <h1>{{ "createAccount" | i18n }}</h1>
         <input type="checkbox" id="acceptPolicies" formControlName="acceptPolicies" />
         <label for="acceptPolicies">
           {{ "acceptPolicies" | i18n }}<br />
-          <a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{
+          <a href="https://bitwarden.com/terms/" target="_blank" rel="noreferrer">{{
             "termsOfService" | i18n
           }}</a
           >,
-          <a href="https://bitwarden.com/privacy/" target="_blank" rel="noopener">{{
+          <a href="https://bitwarden.com/privacy/" target="_blank" rel="noreferrer">{{
             "privacyPolicy" | i18n
           }}</a>
         </label>

diff --git a/apps/web/src/app/admin-console/organizations/manage/user-confirm.component.html b/apps/web/src/app/admin-console/organizations/manage/user-confirm.component.html
@@ -18,7 +18,7 @@ <h1 class="modal-title" id="confirmUserTitle">
       <div class="modal-body">
         <p>
           {{ "fingerprintEnsureIntegrityVerify" | i18n }}
-          <a href="https://bitwarden.com/help/fingerprint-phrase/" target="_blank" rel="noopener">
+          <a href="https://bitwarden.com/help/fingerprint-phrase/" target="_blank" rel="noreferrer">
             {{ "learnMore" | i18n }}</a
           >
         </p>

diff --git a/...b/src/app/admin-console/organizations/members/components/bulk/bulk-confirm.component.html b/...b/src/app/admin-console/organizations/members/components/bulk/bulk-confirm.component.html
@@ -28,7 +28,11 @@ <h1 class="modal-title" id="bulkTitle">
         <ng-container *ngIf="!loading && !done">
           <p>
             {{ "fingerprintEnsureIntegrityVerify" | i18n }}
-            <a href="https://bitwarden.com/help/fingerprint-phrase/" target="_blank" rel="noopener">
+            <a
+              href="https://bitwarden.com/help/fingerprint-phrase/"
+              target="_blank"
+              rel="noreferrer"
+            >
               {{ "learnMore" | i18n }}</a
             >
           </p>

diff --git a/...admin-console/organizations/members/components/member-dialog/member-dialog.component.html b/...admin-console/organizations/members/components/member-dialog/member-dialog.component.html
@@ -37,7 +37,7 @@
               {{ "memberRole" | i18n }}
               <a
                 target="_blank"
-                rel="noopener"
+                rel="noreferrer"
                 appA11yTitle="{{ 'learnMore' | i18n }}"
                 href="https://bitwarden.com/help/user-types-access-control/"
               >
@@ -123,7 +123,7 @@
                 <ng-container *ngIf="!canUseCustomPermissions; else enterprise">
                   <div class="text-base tw-block tw-font-normal tw-text-muted">
                     {{ "customDescNonEnterpriseStart" | i18n
-                    }}<a href="https://bitwarden.com/contact/" target="_blank">{{
+                    }}<a href="https://bitwarden.com/contact/" target="_blank" rel="noreferrer">{{
                       "customDescNonEnterpriseLink" | i18n
                     }}</a
                     >{{ "customDescNonEnterpriseEnd" | i18n }}
@@ -370,7 +370,7 @@ <h3 class="mt-4">
               {{ "secretsManager" | i18n }}
               <a
                 target="_blank"
-                rel="noopener"
+                rel="noreferrer"
                 appA11yTitle="{{ 'learnMore' | i18n }}"
                 href="https://bitwarden.com/help/manage-your-organization/#access-to-secrets-manager"
               >
@@ -415,7 +415,7 @@ <h3 class="mt-4">
                 {{ "accessAllCollectionsDesc" | i18n }}
                 <a
                   target="_blank"
-                  rel="noopener"
+                  rel="noreferrer"
                   appA11yTitle="{{ 'learnMore' | i18n }}"
                   href="https://bitwarden.com/help/user-types-access-control/#access-control"
                 >

diff --git a/apps/web/src/app/admin-console/organizations/settings/account.component.html b/apps/web/src/app/admin-console/organizations/settings/account.component.html
@@ -41,7 +41,7 @@ <h1 bitTypography="h1" class="tw-pb-2.5">{{ "organizationInfo" | i18n }}</h1>
   <h1 bitTypography="h1" class="tw-mt-16 tw-pb-2.5">{{ "apiKey" | i18n }}</h1>
   <p>
     {{ "apiKeyDesc" | i18n }}
-    <a href="https://docs.bitwarden.com" target="_blank" rel="noopener">
+    <a href="https://docs.bitwarden.com" target="_blank" rel="noreferrer">
       {{ "learnMore" | i18n }}
     </a>
   </p>
@@ -62,7 +62,7 @@ <h1 bitTypography="h1" class="tw-mt-16 tw-pb-2.5">
   </h1>
   <p>
     {{ "collectionEnhancementsDesc" | i18n }}
-    <a href="https://bitwarden.com/help/collection-management" target="_blank" rel="noopener">
+    <a href="https://bitwarden.com/help/collection-management" target="_blank" rel="noreferrer">
       {{ "collectionEnhancementsLearnMore" | i18n }}
     </a>
   </p>

diff --git a/apps/web/src/app/auth/migrate-encryption/migrate-legacy-encryption.component.html b/apps/web/src/app/auth/migrate-encryption/migrate-legacy-encryption.component.html
@@ -10,7 +10,7 @@ <h1 bitTypography="h1" class="tw-mb-4 tw-text-center">{{ "updateEncryptionKey" |
           <a
             href="https://bitwarden.com/help/account-encryption-key/#rotate-your-encryption-key"
             target="_blank"
-            rel="noopener"
+            rel="noreferrer"
             >{{ "learnMore" | i18n }}</a
           >
         </p>

diff --git a/apps/web/src/app/auth/recover-two-factor.component.html b/apps/web/src/app/auth/recover-two-factor.component.html
@@ -9,7 +9,7 @@
             <a
               href="https://bitwarden.com/help/lost-two-step-device/"
               target="_blank"
-              rel="noopener"
+              rel="noreferrer"
               >{{ "learnMore" | i18n }}</a
             >
           </p>

diff --git a/apps/web/src/app/auth/register-form/register-form.component.html b/apps/web/src/app/auth/register-form/register-form.component.html
@@ -115,11 +115,11 @@
 
       <bit-label for="register-form-input-accept-policies">
         {{ "acceptPolicies" | i18n }}<br />
-        <a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{
+        <a href="https://bitwarden.com/terms/" target="_blank" rel="noreferrer">{{
           "termsOfService" | i18n
         }}</a
         >,
-        <a href="https://bitwarden.com/privacy/" target="_blank" rel="noopener">{{
+        <a href="https://bitwarden.com/privacy/" target="_blank" rel="noreferrer">{{
           "privacyPolicy" | i18n
         }}</a>
       </bit-label>

diff --git a/apps/web/src/app/auth/settings/change-password.component.html b/apps/web/src/app/auth/settings/change-password.component.html
@@ -103,7 +103,7 @@ <h1>{{ "changeMasterPassword" | i18n }}</h1>
       <a
         href="https://bitwarden.com/help/account-encryption-key/#rotate-your-encryption-key"
         target="_blank"
-        rel="noopener"
+        rel="noreferrer"
         appA11yTitle="{{ 'learnMore' | i18n }}"
       >
         <i class="bwi bwi-question-circle" aria-hidden="true"></i>

diff --git a/...eb/src/app/auth/settings/emergency-access/confirm/emergency-access-confirm.component.html b/...eb/src/app/auth/settings/emergency-access/confirm/emergency-access-confirm.component.html
@@ -18,7 +18,7 @@ <h1 class="modal-title" id="confirmUserTitle">
       <div class="modal-body">
         <p>
           {{ "fingerprintEnsureIntegrityVerify" | i18n }}
-          <a href="https://bitwarden.com/help/fingerprint-phrase/" target="_blank" rel="noopener">
+          <a href="https://bitwarden.com/help/fingerprint-phrase/" target="_blank" rel="noreferrer">
             {{ "learnMore" | i18n }}</a
           >
         </p>

diff --git a/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html b/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html
@@ -49,7 +49,7 @@ <h3>
           {{ "userAccess" | i18n }}
           <a
             target="_blank"
-            rel="noopener"
+            rel="noreferrer"
             appA11yTitle="{{ 'learnMore' | i18n }}"
             href="https://bitwarden.com/help/emergency-access/#user-access"
           >

diff --git a/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html b/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html
@@ -3,7 +3,7 @@ <h1>{{ "emergencyAccess" | i18n }}</h1>
 </div>
 <p>
   {{ "emergencyAccessDesc" | i18n }}
-  <a href="https://bitwarden.com/help/emergency-access/" target="_blank" rel="noopener">
+  <a href="https://bitwarden.com/help/emergency-access/" target="_blank" rel="noreferrer">
     {{ "learnMore" | i18n }}.
   </a>
 </p>

diff --git a/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html b/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html
@@ -11,7 +11,7 @@ <h1>{{ "encKeySettings" | i18n }}</h1>
           class="ml-auto"
           href="https://bitwarden.com/help/kdf-algorithms"
           target="_blank"
-          rel="noopener"
+          rel="noreferrer"
           appA11yTitle="{{ 'learnMore' | i18n }}"
         >
           <i class="bwi bwi-question-circle" aria-hidden="true"></i>
@@ -49,7 +49,7 @@ <h1>{{ "encKeySettings" | i18n }}</h1>
             class="ml-auto"
             href="https://bitwarden.com/help/what-encryption-is-used/#changing-kdf-iterations"
             target="_blank"
-            rel="noopener"
+            rel="noreferrer"
             appA11yTitle="{{ 'learnMore' | i18n }}"
           >
             <i class="bwi bwi-question-circle" aria-hidden="true"></i>

diff --git a/apps/web/src/app/auth/settings/two-factor-authenticator.component.html b/apps/web/src/app/auth/settings/two-factor-authenticator.component.html
@@ -51,7 +51,7 @@ <h1 class="modal-title" id="2faAuthenticatorTitle">
               <a
                 href="https://itunes.apple.com/us/app/authy/id494168017?mt=8"
                 target="_blank"
-                rel="noopener"
+                rel="noreferrer"
                 >Authy</a
               >
             </li>
@@ -60,7 +60,7 @@ <h1 class="modal-title" id="2faAuthenticatorTitle">
               <a
                 href="https://play.google.com/store/apps/details?id=com.authy.authy"
                 target="_blank"
-                rel="noopener"
+                rel="noreferrer"
                 >Authy</a
               >
             </li>
@@ -69,7 +69,7 @@ <h1 class="modal-title" id="2faAuthenticatorTitle">
               <a
                 href="https://www.microsoft.com/p/authenticator/9wzdncrfj3rj"
                 target="_blank"
-                rel="noopener"
+                rel="noreferrer"
                 >Microsoft Authenticator</a
               >
             </li>

diff --git a/apps/web/src/app/billing/individual/premium.component.html b/apps/web/src/app/billing/individual/premium.component.html
@@ -56,7 +56,7 @@ <h1>{{ "goPremium" | i18n }}</h1>
     bitButton
     href="{{ this.cloudWebVaultUrl }}/#/settings/subscription/premium"
     target="_blank"
-    rel="noopener"
+    rel="noreferrer"
     buttonType="secondary"
     *ngIf="selfHosted"
   >

diff --git a/apps/web/src/app/billing/individual/user-subscription.component.html b/apps/web/src/app/billing/individual/user-subscription.component.html
@@ -104,7 +104,7 @@ <h1>
         buttonType="secondary"
         href="{{ this.cloudWebVaultUrl }}/#/settings/subscription"
         target="_blank"
-        rel="noopener"
+        rel="noreferrer"
       >
         {{ "launchCloudSubscription" | i18n }}
       </a>

diff --git a/apps/web/src/app/billing/organizations/download-license.component.html b/apps/web/src/app/billing/organizations/download-license.component.html
@@ -11,7 +11,7 @@ <h3 class="card-body-header">{{ "downloadLicense" | i18n }}</h3>
           <a
             class="ml-auto"
             target="_blank"
-            rel="noopener"
+            rel="noreferrer"
             appA11yTitle="{{ 'learnMore' | i18n }}"
             href="https://bitwarden.com/help/licensing-on-premise/#organization-account-sharing"
           >

diff --git a/apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html b/apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html
@@ -40,7 +40,7 @@ <h1>
         href="https://bitwarden.com/help/licensing-on-premise/#update-organization-license"
         target="_blank"
         [appA11yTitle]="'licensePaidFeaturesHelp' | i18n"
-        rel="noopener"
+        rel="noreferrer"
       >
         <i class="bwi bwi-question-circle" aria-hidden="true"></i>
         <span class="sr-only">{{ "licensePaidFeaturesHelp" | i18n }}</span>
@@ -68,7 +68,7 @@ <h1>
     buttonType="secondary"
     href="{{ this.cloudWebVaultUrl }}"
     target="_blank"
-    rel="noopener"
+    rel="noreferrer"
   >
     {{ "launchCloudSubscription" | i18n }}
   </a>
@@ -88,7 +88,7 @@ <h2 class="mt-5">
           <a
             href="https://bitwarden.com/help/families-for-enterprise-self-hosted/"
             target="_blank"
-            rel="noopener"
+            rel="noreferrer"
           >
             <i class="bwi bwi-question-circle" aria-hidden="true"></i>
             <span class="sr-only">{{ "billingSyncHelp" | i18n }}</span>

diff --git a/apps/web/src/app/billing/shared/billing-history.component.html b/apps/web/src/app/billing/shared/billing-history.component.html
@@ -8,13 +8,13 @@ <h2 class="mt-3">{{ "invoices" | i18n }}</h2>
         <a
           href="{{ i.pdfUrl }}"
           target="_blank"
-          rel="noopener"
+          rel="noreferrer"
           class="mr-2"
           appA11yTitle="{{ 'downloadInvoice' | i18n }}"
         >
           <i class="bwi bwi-file-pdf" aria-hidden="true"></i
         ></a>
-        <a href="{{ i.url }}" target="_blank" rel="noopener" title="{{ 'viewInvoice' | i18n }}">
+        <a href="{{ i.url }}" target="_blank" rel="noreferrer" title="{{ 'viewInvoice' | i18n }}">
           {{ "invoiceNumber" | i18n: i.number }}</a
         >
       </td>

diff --git a/apps/web/src/app/billing/shared/payment.component.html b/apps/web/src/app/billing/shared/payment.component.html
@@ -83,7 +83,7 @@
           href="https://www.cvvnumber.com/cvv.html"
           tabindex="-1"
           target="_blank"
-          rel="noopener noreferrer"
+          rel="noreferrer"
           class="ml-auto"
           appA11yTitle="{{ 'learnMore' | i18n }}"
         >

diff --git a/apps/web/src/app/layouts/header/web-header.component.html b/apps/web/src/app/layouts/header/web-header.component.html
@@ -61,11 +61,16 @@
                 <i class="bwi bwi-fw bwi-user" aria-hidden="true"></i>
                 {{ "accountSettings" | i18n }}
               </a>
-              <a bitMenuItem href="https://bitwarden.com/help/" target="_blank" rel="noopener">
+              <a bitMenuItem href="https://bitwarden.com/help/" target="_blank" rel="noreferrer">
                 <i class="bwi bwi-fw bwi-question-circle" aria-hidden="true"></i>
                 {{ "getHelp" | i18n }}
               </a>
-              <a bitMenuItem href="https://bitwarden.com/download/" target="_blank" rel="noopener">
+              <a
+                bitMenuItem
+                href="https://bitwarden.com/download/"
+                target="_blank"
+                rel="noreferrer"
+              >
                 <i class="bwi bwi-fw bwi-download" aria-hidden="true"></i>
                 {{ "getApps" | i18n }}
               </a>

diff --git a/apps/web/src/app/layouts/navbar.component.html b/apps/web/src/app/layouts/navbar.component.html
@@ -75,11 +75,11 @@
               <i class="bwi bwi-fw bwi-user" aria-hidden="true"></i>
               {{ "accountSettings" | i18n }}
             </a>
-            <a bitMenuItem href="https://bitwarden.com/help/" target="_blank" rel="noopener">
+            <a bitMenuItem href="https://bitwarden.com/help/" target="_blank" rel="noreferrer">
               <i class="bwi bwi-fw bwi-question-circle" aria-hidden="true"></i>
               {{ "getHelp" | i18n }}
             </a>
-            <a bitMenuItem href="https://bitwarden.com/download/" target="_blank" rel="noopener">
+            <a bitMenuItem href="https://bitwarden.com/download/" target="_blank" rel="noreferrer">
               <i class="bwi bwi-fw bwi-download" aria-hidden="true"></i>
               {{ "getApps" | i18n }}
             </a>

diff --git a/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html b/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html
@@ -38,7 +38,7 @@
         bitLink
         [href]="product.marketingRoute"
         target="_blank"
-        rel="noopener noreferrer"
+        rel="noreferrer"
       >
         <span class="tw-flex tw-items-center tw-font-normal">
           <i class="bwi bwi-fw {{ product.icon }} tw-m-0 !tw-mr-3"></i>{{ product.name }}