Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specification and wording of BSIP 81 #271

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Conversation

abitmore
Copy link
Member

It's found that the specification was not clear enough.
See also: bitshares/bitshares-core#2136 (comment)

It's found that the specification was not clear enough.
See also: bitshares/bitshares-core#2136 (comment)
@abitmore
Copy link
Member Author

This pull request changes only implementation details, I think it doesn't require a re-vote.

Copy link
Contributor

@MichelSantos MichelSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does clear up the issue; thank you @abitmore. I also agree that the clarification maintains the spirit of the original BSIP.

@sschiessl-bcp
Copy link
Collaborator

sschiessl-bcp commented Apr 17, 2020

Since we are touching this BSIP can we add the remark that market fee is enabled for the market fees to be taken?

This sentence is not true strictly, only if market fee flag is enabled (market fee can be set but flag disabled, correct?)
"Before the consensus upgrade, when an order buying that asset got filled, the amount [...] will enter the asset's market fee sharing process."

@abitmore
Copy link
Member Author

To be honest I'm not a fan of spending time on tweaking the wordings. On one hand English is not my native language, on the other hand the spirit of the BSIP and the change is clear enough, the most important thing to put our efforts on is to push forward fast. The things didn't describe in the text is simply won't be changed. Since the system is already quite complex and it lacks of detailed documentation, IMHO this BSIP is not the best place to explain all the details and to finish all the docs. KISS.

Actually I already feel the "capped by max market fee" sentence is already annoying as we have to repeat it again and again but it's not the most important thing to focus on in this document, I'd rather avoid mention it at all. The "market fee sharing process" phrase is similar.

If I'm not getting productive help here, I don't mind to merge it without anyone else's approval.

@abitmore
Copy link
Member Author

IMHO the "market fee sharing process" implies several things, one of them is "if the asset doesn't enable the charge_market_fee flag, no fee will be charged".

@sschiessl-bcp
Copy link
Collaborator

Sounds good. Update makes it clearer

@abitmore abitmore merged commit d4e2e23 into master Apr 19, 2020
@abitmore abitmore deleted the bsip81-update branch April 19, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants