Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3] 3.0.0 call_price field #2634

Closed
4 of 5 tasks
abitmore opened this issue Apr 23, 2019 · 8 comments · Fixed by #2636
Closed
4 of 5 tasks

[3] 3.0.0 call_price field #2634

abitmore opened this issue Apr 23, 2019 · 8 comments · Fixed by #2636
Assignees
@startailcoon
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [2] Verified Issue has been verified by a team member [3] Refactoring Classification indicating a change to code refactoring. [4d] Critical Priority Priority indicating system stoppage may occur and no workaround exists [5c] Medium Indicates size of task. Est. between two and four hours [6] Core Impact flag identifying related to bitshares-core
Milestone
190426

Comments

@abitmore
Copy link
Member

abitmore commented Apr 23, 2019 •
edited by startailcoon
Loading

Is your feature request related to a problem? Please describe.

Margin positions' call_price field will be always 1 after the consensus upgrade (23rd Apr 2019). If we still want to show a "call price" field in UI, we should calculate using other fields. See https://github.com/bitshares/bitshares-core/wiki/Testing-HF-1270:-Effects-of-MCR-Change-on-Call-Price#-3-feed-publisher-changes-mcr-to-20

The call_price field of every loan will always appear with an effective price of 1.0 after the hardfork. The call_price of the bitasset is now left as a calculation to client software to calculate. The call price of the bitasset denominated in the collateral token (e.g. bitCNY/BTS) should be calculated as

call_price = (collateral × MCR) ÷ debt

Related pages:

  • account - debt positions
    image

  • asset - debt positions
    image

  • market page - buy/sell orders
    image

  • market page - call limit

  • other pages

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@clockworkgr clockworkgr added [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [2] Verified Issue has been verified by a team member [3] Refactoring Classification indicating a change to code refactoring. [4d] Critical Priority Priority indicating system stoppage may occur and no workaround exists [5c] Medium Indicates size of task. Est. between two and four hours [6] Core Impact flag identifying related to bitshares-core labels Apr 23, 2019
@sschiessl-bcp
Copy link
Contributor

What's the reason for this change?

@clockworkgr
Copy link
Member

does it matter? it's not like core can be changed back right now :)

@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Apr 23, 2019 via email

@clockworkgr
Copy link
Member

curiosity killed the cat

@startailcoon startailcoon self-assigned this Apr 23, 2019
@startailcoon
Copy link
Contributor

Will look at this today

@abitmore
Copy link
Member Author

abitmore commented Apr 23, 2019 •
edited
Loading

What's the reason for this change?

Because

  1. we can't update it every time when MCR changes, we will not use it anymore in core after the upgrade, if leave it unchanged, the value would be probably inconsistent (aka wrong), see Call price is inconsistent when MCR changed bitshares-core#1270
  2. being always 1 has slightly better performance than leaving it unchanged in the long run

@bangzi1001 bangzi1001 mentioned this issue Apr 23, 2019
Closed
@startailcoon startailcoon mentioned this issue Apr 23, 2019
Merged
@startailcoon startailcoon changed the title 3.0.0 call_price field [3] 3.0.0 call_price field Apr 23, 2019
@startailcoon startailcoon added this to the 190426 milestone Apr 23, 2019
@startailcoon
Copy link
Contributor

This should now be resolved in PR

@clockworkgr
Copy link
Member

good job @startailcoon ...is it on staging or develop yet so we can test out if everything appears normal?

@sschiessl-bcp sschiessl-bcp mentioned this issue Apr 25, 2019
Merged
sschiessl-bcp pushed a commit that referenced this issue Apr 25, 2019
Merge pull request #2639 from bitshares/staging
02c28de 
hotfix for call price issue #2634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@startailcoon startailcoon

Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [2] Advanced Issue Issue is a technically advanced or complex task. Requires prior knowledge [2] Verified Issue has been verified by a team member [3] Refactoring Classification indicating a change to code refactoring. [4d] Critical Priority Priority indicating system stoppage may occur and no workaround exists [5c] Medium Indicates size of task. Est. between two and four hours [6] Core Impact flag identifying related to bitshares-core
Projects
None yet
Milestone
190426
Development

Successfully merging a pull request may close this issue.

Issue 2634 - Fixes for call_price changes in core bitshares/bitshares-ui
4 participants
@clockworkgr @abitmore @startailcoon @sschiessl-bcp