Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.25] Automatic switching bug #1388

Closed
sschiessl-bcp opened this issue Apr 3, 2018 · 4 comments
Closed

[.25] Automatic switching bug #1388

sschiessl-bcp opened this issue Apr 3, 2018 · 4 comments
Assignees
@svk31
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
180418

Comments

@sschiessl-bcp
Copy link
Contributor

When I toggle automatic switching on or off
image
I often get the following error
image

Anyone else getting that?
@sschiessl-bcp
Copy link
Contributor Author

sschiessl-bcp commented Apr 3, 2018 •
edited
Loading

I have no account created yet, so AccountStore.getState().currentAccount in BrowserNotificationsContainer is null.

I would provide a fix for it.

@svk31
Copy link
Contributor

svk31 commented Apr 3, 2018

I saw this a few times too but thought I already fixed it. Would be helpful if you could click where it says BrowserNotifications.jsx:62 and show me the line where that takes you.

@sschiessl-bcp
Copy link
Contributor Author

Its in line 42, I added that it also checks if props.account exists

@svk31
Copy link
Contributor

svk31 commented Apr 3, 2018

Oh of course, I didn't notice that it's also doing this.props.account.get, not just nextProps.account.get

@svk31 svk31 closed this as completed in 702c1ce Apr 3, 2018
@wmbutler wmbutler changed the title Automatic switching bug [.25] Automatic switching bug Apr 3, 2018
@wmbutler wmbutler added this to the 180415 milestone Apr 3, 2018
@wmbutler wmbutler added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Apr 3, 2018
ruslansalikhov pushed a commit to blckchnd/rudex-ui that referenced this issue Apr 4, 2018
@svk31
bitshares#1388: Set set_subscribe_callback boolean to false
75b7034
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
bitshares#1388: Set set_subscribe_callback boolean to false
dee0ad5
Cryptolero pushed a commit to CryptoBridge/cryptobridge-ui that referenced this issue Nov 2, 2018
@svk31
Fix bitshares#1388: Check if this.props.account exists before using i…
c73c241 
…t in BrowserNotifications
@TechsUsInc TechsUsInc mentioned this issue Dec 4, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svk31 svk31

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
180418
Development

No branches or pull requests
3 participants
@wmbutler @svk31 @sschiessl-bcp