forked from steemit/fc
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve safe<T> #248
Merged
Merged
Improve safe<T> #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
improve-safe-t
branch
2 times, most recently
from
March 26, 2023 13:26
a5bcc6c
to
15d8282
Compare
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
abitmore
force-pushed
the
improve-safe-t
branch
4 times, most recently
from
March 29, 2023 10:30
2661364
to
f5ed516
Compare
1 task
abitmore
force-pushed
the
improve-safe-t
branch
2 times, most recently
from
March 29, 2023 12:17
c7f65ef
to
d100f00
Compare
* support only integers, both signed and unsigned * check overflow and underflow on initialization * fix issues when T is unsigned * add tests * remove explicitly declared copy constructor, so that the compiler will implicitly declare copy constructors, move constructors, assignment operators, etc
instead of ubuntu-latest
as it is now by default
for better coverage reporting, including branch coverage
abitmore
force-pushed
the
improve-safe-t
branch
from
March 29, 2023 13:49
d100f00
to
e30d286
Compare
Kudos, SonarCloud Quality Gate passed! |
This was referenced Mar 29, 2023
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for bitshares/bitshares-core#2147.
safe<T>
v3
ubuntu-latest
which is now Ubuntu 22gcovr
to process code coverage data for better coverage reporting, including branch coverage