Settlement code refactory #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...idual_settlement() to is_globally_settled() and is_individually_settled_to_fund() for intuition
5 tasks
Store settled debt amounts and collateral amounts in bitasset objects instead of limit orders.
abitmore
force-pushed
the
settlement-code-refactory
branch
from
85148a1 to
f8d5e8d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #2721.
Changes:
has_settlement()andhas_individual_settlement()tois_globally_settled()andis_individually_settled_to_fund()for intuition.individual_settlement_debtandindividual_settlement_fundfields in bitasset object instead of new data fields in limit order.Note: Due to this change, the 2 fields will become non-zero when individual settlement occurs and BSRM is
individual_settlement_to_order. It may break some client applications which rely on the old logic "the 2 fields will be always zero if BSRM isindividual_settlement_to_order".