Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to account history plugin to keep operations that happened in last X blocks in memory #2648

Merged
merged 16 commits into from
Oct 3, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Oct 1, 2022

PR for #2268.

Note: this triggers auto-replay.

Add 2 node startup options (available when the account_history plugin is enabled):

  • min-blocks-to-keep - Operations which are in the latest X blocks will be kept in memory. This option only takes effect when track-account is not used and max-ops-per-account is not zero. Note that this option may cause more history records to be kept in memory than the limit defined by the max-ops-per-account option, but the amount will be limited by the max-ops-per-acc-by-min-blocks option. The default value is 30,000 blocks.
  • max-ops-per-acc-by-min-blocks - A potential higher limit on the maximum number of operations per account to be kept in memory when the min-blocks-to-keep option causes the amount to exceed the limit defined by the max-ops-per-account option. If this is less than max-ops-per-account, max-ops-per-account will be used. The default value is 1,000 records.

@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Oct 1, 2022
@abitmore abitmore changed the base branch from pr-487-account-history-time to develop October 1, 2022 21:56
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

94.9% 94.9% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit f814334 into develop Oct 3, 2022
@abitmore abitmore deleted the pr-2268-account-history-by-blocks branch October 3, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the account history plugin to store the recent oho in the memory.
1 participant