Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block_time and is_virtual fields to operation_history_object #2642

Merged
merged 5 commits into from
Oct 1, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Sep 16, 2022

PR for #487 (note: this PR depends on #2639).

Note: this triggers auto-replay.

Adds 2 fields to operation_history_object

  • is_virtual
  • block_time
   class operation_history_object : public abstract_object<operation_history_object>
   {
         operation         op;
         operation_result  result;
         /** the block that caused this operation */
         uint32_t          block_num = 0;
         /** the transaction in the block */
         uint16_t          trx_in_block = 0;
         /** the operation within the transaction */
         uint16_t          op_in_trx = 0;
         /** any virtual operations implied by operation in block */
         uint32_t          virtual_op = 0;
         /** Whether this is a virtual operation */
         bool              is_virtual = false;
         /** The timestamp of the block that caused this operation */
         time_point_sec    block_time;
   };

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@abitmore abitmore changed the base branch from pr-2586-account-asset-creation-dates to develop October 1, 2022 21:54
@abitmore abitmore merged commit 315a0c3 into develop Oct 1, 2022
@abitmore abitmore deleted the pr-487-account-history-time branch October 1, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestamps in get_relative_account_history() call
1 participant