Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend get_block_header and get_block_header_batch APIs to return witness signatures #2641

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Extend get_block_header and get_block_header_batch APIs to return witness signatures #2641

merged 3 commits into from
Sep 16, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Sep 16, 2022 •
edited
Loading

PR for #2588.

Update: this PR is superseded by #2652.

Note: the `witness_signature` field is a bit long, so the return size has increased.

Before:

{"previous":"00000004659ea6a0ae8928db63338ca9b16e4a70","timestamp":"2015-05-15T14:27:20","witness":"1.6.6","transaction_merkle_root":"3d1a3de0a1de97f7b300846e1f2ec5b0c84179e2","extensions":[]}

After:

{"previous":"00000004659ea6a0ae8928db63338ca9b16e4a70","timestamp":"2015-05-15T14:27:20","witness":"1.6.6","transaction_merkle_root":"3d1a3de0a1de97f7b300846e1f2ec5b0c84179e2","extensions":[],"witness_signature":"204e4172a77f89749e2a6a00eaf069c88dfb0ca2f985ba86c8f0b5a7e39d41b82953defea5805f510b83b40ef7f8ee11ad9f43a8a51ea72520a600bebd44a23534"}

@abitmore
Extend get_block_header* APIs to return signatures
3ab613e 
Including 2 database APIs:
- get_block_header
- get_block_header_batch
@abitmore
Add tests for get_block* APIs
d8c8f01
@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Sep 16, 2022
@abitmore abitmore linked an issue Sep 16, 2022 that may be closed by this pull request
Add a new database API to get signed block header #2588
Closed
17 tasks
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit 60ef74b into develop Sep 16, 2022
@abitmore abitmore deleted the pr-2588-signed-block-header-api branch September 16, 2022 21:29
@abitmore abitmore mentioned this pull request Sep 16, 2022
Closed
17 tasks
@abitmore abitmore mentioned this pull request Oct 5, 2022
Merged
@abitmore abitmore removed a link to an issue Oct 5, 2022
Add a new database API to get signed block header #2588
Closed
17 tasks
@abitmore abitmore linked an issue Oct 5, 2022 that may be closed by this pull request
Add a new database API to get signed block header #2588
Closed
17 tasks
@abitmore abitmore mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0 - Feature Release
Development

Successfully merging this pull request may close these issues.

Add a new database API to get signed block header
1 participant
@abitmore