Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for project submodules. #2329

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Add a check for project submodules. #2329

merged 1 commit into from
Jan 9, 2021

Conversation

philmb3487
Copy link

Greetings.
I have added this check in the CMakeList that warns users if the submodules are missing. It might be useful.

Note: try 2, should be good.?

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

One issue with this approach is that the MANUAL_SUBMODULES parameter will be cached in CMakeCache.txt once it is specified, then the next time when running cmake without the parameter, the submodule versions won't get checked unexpectedly.

@philmb3487
Copy link
Author

Thanks.

One issue with this approach is that the MANUAL_SUBMODULES parameter will be cached in CMakeCache.txt once it is specified, then the next time when running cmake without the parameter, the submodule versions won't get checked unexpectedly.

that should be fine, it should catch the first build for newbies that forget to init the submodules, the others probably know to do it.

@philmb3487
Copy link
Author

Does this do what you asked?

abitmore
abitmore previously approved these changes Jan 9, 2021
@abitmore abitmore changed the base branch from develop to release January 9, 2021 17:45
@abitmore abitmore dismissed their stale review January 9, 2021 17:45

The base branch was changed.

@abitmore
Copy link
Member

abitmore commented Jan 9, 2021

Thanks. I'll merge it when it passed CI testing.

@abitmore abitmore merged commit c62e219 into bitshares:release Jan 9, 2021
@philmb3487 philmb3487 deleted the CHECKSM branch January 9, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants