-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions to several asset operations #2176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for BSIP 48, 75 and 77
abitmore
force-pushed
the
pr-bsip75-bitasset-ops
branch
from
May 15, 2020 15:29
12ddc85
to
7330afe
Compare
The new max supply should not be lower than the asset's current supply
The global_settle permission should always be enabled for PM
The old equality function of the price_feed struct was misleading since it did not compare all member variables. This commit replaces it with a new member function.
abitmore
force-pushed
the
pr-bsip75-bitasset-ops
branch
from
May 17, 2020 00:50
6d49395
to
5796380
Compare
Calculate and update asset_object::current_*_collateralization in one function
Ready for review. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BSIP 48, 75 and 77
Features:
flags
1
) inflags
when creating an asset, and can not be unset (to0
) when updating the asset (and the non-buggy part: can not set the unknown bits when updating);flags
;flags
; if a bit was already set, when updating the asset, it must be unset.max_supply
global_settle
permission of prediction marketsglobal_settle
permission of prediction markets can be disabled viaasset_update_operation
, if done so, it can't be enabled again if supply is not zero;global_settle
permission must be enabled innew_options
, and it's allowed to be enabled if was disabled before the hard fork.TODO: