-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Building on OpenBSD #1910
Support Building on OpenBSD #1910
Conversation
8819b80
to
9d0c0c7
Compare
Interesting. I wonder why these changes are necessary. OpenBSD uses Clang, right? Which boost version? |
Yes, OpenBSD switched to clang few years ago. OpenBSD requires some modifications to boost to compile correctly, so I finally used the upstream version, 1.66.0p4 if I'm not mistaken. |
libraries/app/util.cpp
Outdated
@@ -34,9 +34,22 @@ using boost::multiprecision::uint256_t; | |||
|
|||
static fc::uint128_t to_capped_128( const uint256_t& t ) | |||
{ | |||
#if defined(__OpenBSD__) | |||
const fc::uint128_t max = std::numeric_limits<fc::uint128_t>::max(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not an OpenBSD problem but a Clang problem. @nathanhourt ran into it as well. He said it can be fixed by enabling compiler extensions in CMakeLists.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1941
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. The change is now gone.
9d0c0c7
to
26cebe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Haven't tested on OpenBSD.
Thanks!
Hey Monkeys!
I had some interest in being able to run a BitShares node on OpenBSD.
This PR with this bitshares-fc PR contains changes allowing to successfully build the code base under OpenBSD.
The work is not done yet, because, at least for me, the compiled executables crash (with a segmentation fault) on calling some boost functions (hastily done some call tracing).
I plan to investigate further. So far, I wanted to share and close the work already done.
Ape out!