Fix chain_test: Committee and witnesses initialization in genesis #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
changed the title
|
FWIW this PR is relate to #183. |
abitmore
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was caused by a sporadic fail of the htlc_expires test on our CI. However, later this test was fixed. While we were researching the problem, we found out that committee proposals aren't always authorized. In the case of htlc_expires this was caused by installing updatable_htlc_options in global parameters. As a result, it was decided to write a unit test which demonstrates the problem and also to make a correction that fixes it.
There are oddity checks in database::init_genesis():
But size of containers genesis_state.initial_witness_candidates and genesis_state.initial_committee_candidates are not checked. So, all candidates become witnesses and committee members. In database_fixture these containers are initialized with 10 elements. In some tests committee can't make decision without correct initialization.