put seed nodes into separate file

[crypto-ape]

Hey Monkeys!

This change isolates the hard-coded seed nodes into separate file.

Ape out!

[oxarbitrage]

• I think it can be a good idea to put this in a separated file but i will like opinions from others.

• I personally dont like the implementation with the #include in the middle of the code. Even if in this case it can be harmless, it just dont looks right. We can read the text file line by line and it should be a better approach IMHO.

• The location of this file should not be at root, maybe libraries/egenesis or programs/witness_node are better places.

[01mk]

This is brilliant lazy programmer solution 😄

It would be much better to read it from some kind of config file.

[crypto-ape]

Yes, it was a brilliantly pragmatic solution.

• I agree that the file should be located more appropriately, 'libraries/egenesis' does not sound bad.
• Yes, the raw include is both elegant and ugly, not systematic. Reading a file line by line sounds right.

I will wait a while before refactoring it until a more profound consensus is reached.

[pmconrad]

the raw include is both elegant and ugly

Agree. I like it. :-)

I think you can get rid of the CMakeLists change if you #include with double quotes not angled brackets.

[pmconrad]

It would be much better to read it from some kind of config file.

We have a config file. The list here is meant to provide a working hardcoded default.
IMO using a tool like embed_genesis for something that can be solved with a simple #include is overkill.

[pmconrad]

Inactive, please remove

[oxarbitrage]

Agree. I like it. :-)

Ok , i don't have anything against it apart from being a bit ugly as mentioned, the include do what is needed.

I think you can get rid of the CMakeLists change if you #include with double quotes not angled brackets.

It will look better to me if we can do this changes, it will make the intention more clear as it will distinct it from normal angled bracket headers plus save the CMakeList changes.

[crypto-ape]

I have refactored the PR.

• the CMakeLists.txt is not modified
• the raw include is used ("seed-nodes.txt")
• the added file with seed node entries also contains link to the forum topic
• the inactive nodes are removed (@pmconrad You can check this, I also inspected the servers with nc -vc address port.)

[pmconrad]

Hm somehow this looks wrong. I meant to remove puppies, Harvey, lafona, wackou, BlockTrades, cube.
You left in Harvey but removed liondani. liondani seems to be a bit unreliable, but please leave him in.
I always get "Connection refused" for Harvey, was it successful for you?

lafona has a new seed: bts.lafona.net:1776, please re-add.

[crypto-ape]

(I don't remember, but now I obtained a refusal from Harvey as You did.)

I have re-added lafona and removed Harvey.

[pmconrad]

Thanks!