Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build simplification #1547

Merged
merged 13 commits into from
Jan 31, 2019
Merged

Build simplification #1547

merged 13 commits into from
Jan 31, 2019

Conversation

pmconrad
Copy link
Contributor

  • Got rid of more boost dependencies
  • Improvements to docker build
  • Improvements to travis build

Includes similar changes in FC, see bitshares/bitshares-fc#104 .

The fc bump comes with a number of additional changes - FC PR's 99-103.

abitmore
abitmore previously approved these changes Jan 30, 2019
View reviewed changes
jmjatlanta
jmjatlanta previously approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled fine on Ubuntu 18.10 / Boost 1.67 / OpenSSL 1.1

@pmconrad
Copy link
Contributor Author

Thanks. Waiting to see if Docker build works.

@pmconrad pmconrad dismissed stale reviews from jmjatlanta and abitmore via e1eb934 January 30, 2019 21:36
@pmconrad
Copy link
Contributor Author

Docker build now runs into different problem... :-/
db_update.cpp:(.text+0x26733): undefined reference to 'fc::smart_ref<graphene::chain::fee_schedule>::operator*() const'
:-(

jmjatlanta
jmjatlanta approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmconrad pmconrad merged commit 5503152 into develop Jan 31, 2019
@pmconrad pmconrad deleted the build_simplification branch January 31, 2019 20:09
@jmjatlanta jmjatlanta mentioned this pull request Jan 31, 2019
Closed
3 tasks
@pmconrad pmconrad mentioned this pull request Feb 1, 2019
Open
24 tasks
@abitmore abitmore added this to the 201902 - Feature Release milestone Feb 5, 2019
@MichelSantos MichelSantos mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta approved these changes

@abitmore abitmore abitmore left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201902 - Feature Release
Development

Successfully merging this pull request may close these issues.
3 participants
@pmconrad @jmjatlanta @abitmore