-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid calling exit from inside library, and removed "create-genesis-json" startup option #1529
Conversation
IMO the |
I can certainly do that. I do believe that option is part of some instructions (private testnet perhaps?), so cleaning the documentation would be required. @abitmore I would appreciate your opinion. |
I prefer keeping the code if it leads to less work. |
Accepting this PR will be the least work of course, but IMO the end result would be better if my suggestion was implemented. |
Please resolve conflicts, then I'll approve. |
Created issue #1536 for tracking documentation work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #1110
Calling
exit
from inside a library makes unit testing impossible. This fix uses return values to indicate if the application should end or continue.