Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors - replaces #1421 #1426

Merged
merged 3 commits into from
Nov 10, 2018

Conversation

oxarbitrage
Copy link
Member

cherry pick the 2 commits in #1421 by @nathanhourt as we need the changes in develop branch.

Potential optimization: don't move a temporary as this prevents
copy elision
 - Add missing FC_REFLECT_TYPENAME on account operation extentions
 - Replace deprecated call to fc::rand_pseudo_bytes with
fc::rand_bytes.
Required for build on some configurations
@nathanielhourt
Copy link
Contributor

Oops, my bad. I'll PR to develop in the future :)

Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants