More 32 bit to 64 bit changes #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
approved these changes
Oct 9, 2018
|
Perhaps we can include this in 201810 release? BTW I'd like to keep the issue open for future findings even after merged this. Thoughts? |
|
Agree about keeping the issue open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1206
There are 32 bit variables all throughout the code. Each one could stand to be reviewed (over 2000 by my count). This PR takes care of a few that were being used as counters that could overflow.
Blindly converting all 32 bit values to 64 bit is not advisable. Neither is attempting to review every 32 bit variable within 1 github issue. This PR takes care of the few that were found in issue #1206.