Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2 bugs reported by sonarqube #1185

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Fix 2 bugs reported by sonarqube #1185

merged 1 commit into from
Jul 26, 2018

Conversation

pmconrad
Copy link
Contributor

No description provided.

abitmore
abitmore approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abitmore
Copy link
Member

abitmore commented Jul 26, 2018 •
edited
Loading

Travis-CI complained:

189434ms th_a application.cpp:287 reset_websocket_serv ] Configured websocket rpc to listen on 127.0.0.1:681
189434ms th_a application.cpp:447 startup ] 13 N11websocketpp9exceptionE: Underlying Transport Error

...

The job exceeded the maximum time limit for jobs, and has been terminated.

Update: restarted Travis-CI job and it passed.

oxarbitrage
oxarbitrage approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, travis failing is unrelated here and is work in progress #1187

@abitmore abitmore merged commit 1f625f8 into develop Jul 26, 2018
@abitmore abitmore deleted the sonar_bugs branch July 26, 2018 21:33
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
@pmconrad pmconrad mentioned this pull request Feb 1, 2019
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
3 participants
@pmconrad @abitmore @oxarbitrage