Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

jmjatlanta · 2018-06-13T11:33:48Z

The issue bitshares/bitshares-ui#1338 is now complete. Now defaulting the parameter enable_subscribe_to_all to false

A bit of history: This parameter was documented incorrectly, which caused the ui to send true, which in turn caused the API server to spam the clients with unwanted notifications. Now that the bitshares-ui has been corrected, we can default this parameter to false and avoid sending these unwanted notifications.

PR for #752.

oxarbitrage

thanls @jmjatlanta

abitmore · 2018-06-13T12:24:45Z

Please be careful since it will break old clients (due to quality control of bitshares-ui project, I guess quite some people are still using old versions).

jmjatlanta · 2018-06-13T12:30:36Z

What steps can we take to minimize the impact? We'll have it in the release notes, but I'd imagine most ui users could care less about core changes.

We could delay this change to a later release. But I don't know if we want to do that or not.

Opinions? Other ideas?

cogutvalera

GUI is ready and required code in core is uncommented. Seems everything is fine here. Thanks !

abitmore · 2018-08-17T15:09:25Z

Let's do it in next release. Need to resolve conflicts now.

abitmore · 2018-08-23T12:38:32Z

libraries/app/application.cpp

@@ -943,12 +942,11 @@ void application::set_program_options(boost::program_options::options_descriptio
         ("api-access", bpo::value<boost::filesystem::path>(), "JSON file specifying API permissions")
         ("plugins", bpo::value<string>(), "Space-separated list of plugins to activate")
         ("io-threads", bpo::value<uint16_t>()->implicit_value(0), "Number of IO threads, default to 0 for auto-configuration")
+         ("enable-subscribe-to-all", bpo::value<bool>()->implicit_value(false),


I think the implicit value should be true which is more natural.

abitmore

See comment above.

abitmore · 2018-08-27T16:25:32Z

libraries/app/include/graphene/app/application.hpp

@@ -38,7 +38,7 @@ namespace graphene { namespace app {
   class application_options
   {
      public:
-         bool enable_subscribe_to_all = false;
+         bool enable_subscribe_to_all = true;


Don't change this one to true.

Sorry, my above comment was not clear enough. Expected behavior:

this option is disabled by default (if not specified in config.ini nor startup parameters);

if a user specified it in parameters or config.ini, if without =X (only --enable-subscribe-to-all but not --enable-subscribe-to-all=true), consider the value is true.

jmjatlanta · 2018-09-01T18:23:00Z

I believe I have done what you asked @abitmore but please check. Either I am doing something wrong, or there is a side-effect here.

Adding --enable-subscribe-to-all to the command line sets enable_subscribe_to_all to true which is expected.
Not specifying --enable-subscribe-to-all on the command line sets enable_subscribe_to_all to false which is expected.
Commenting out enable-subscribe-to-all in config.ini sets enable_subscribe_to_all to false which is expected.
Uncommenting enable-subscribe-to-all in config.ini and setting it to true sets enable_subscribe_to_all to true which is expected.
Uncommenting enable-subscribe-to-all in config.ini and setting it to false sets enable_subscribe_to_all to true which is not expected.

I believe that the default config.ini should be generated with the commented out line, but without the = as it is misleading. Is that correct, or am I doing something else incorrect?

clockworkgr · 2018-09-01T18:39:28Z

If this was a dynamically typed language this is exactly the sort of behaviour I'd expect if the value of enable-subscribe-to-all in config.ini was stored as a string and then evaluated as a Boolean.

Seeing as this is C++, I have no idea

abitmore · 2018-09-01T19:27:03Z

I guess @clockworkgr is correct. For example, the partial-operations option generated in config.ini is 1 but not true. Actually I don't remember if I've ever tried to set it to false.

abitmore · 2018-09-01T19:28:51Z

libraries/app/application.cpp

@@ -410,7 +410,7 @@ void application_impl::startup()
   }

   if( _options->count("enable-subscribe-to-all") )
-      _app_options.enable_subscribe_to_all = _options->at("enable-subscribe-to-all").as<bool>();


Sorry, I didn't get it, what's wrong with _options->at("enable-subscribe-to-all").as<bool>();?

If you don't add the command line option, you get an index out of range error.

Update: Okay, I see what you mean. I'm fixing it.

jmjatlanta · 2018-09-01T20:38:26Z

Okay, I have fixed the config.ini problem. It was an error in my logic, as @abitmore pointed out. Now the command line and config.ini file work as expected. A 1/0 or true/false can work in config.ini as expected.

abitmore · 2018-09-03T00:29:29Z

libraries/app/application.cpp

@@ -409,8 +409,8 @@ void application_impl::startup()
      _force_validate = true;
   }

-   if( _options->count("enable-subscribe-to-all") )
-      _app_options.enable_subscribe_to_all = true;
+   if (_options->count("enable-subscribe-to-all"))


Why change the white-spaces? :P

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete

d370b3f

oxarbitrage previously approved these changes Jun 13, 2018

View reviewed changes

abitmore added the 2a Discussion Needed Prompt for team to discuss at next stand up. label Jul 21, 2018

abitmore added this to the Future Non-Consensus-Changing Release milestone Jul 21, 2018

cogutvalera previously approved these changes Aug 14, 2018

View reviewed changes

abitmore modified the milestones: Future Non-Consensus-Changing Release, 201810 - Non-Consensus-Changing Release Aug 17, 2018

abitmore assigned jmjatlanta Aug 23, 2018

Fix merge conflict

e02ad1f

jmjatlanta dismissed stale reviews from cogutvalera and oxarbitrage via e02ad1f August 23, 2018 02:39

abitmore reviewed Aug 23, 2018

View reviewed changes

abitmore requested changes Aug 23, 2018

View reviewed changes

enable subscribe_to_all by default

bab3348

abitmore requested changes Aug 27, 2018

View reviewed changes

jmjatlanta added 2 commits September 1, 2018 13:14

Make default cl param not take boolean

7b02d9a

Remove test code

1c3cc77

abitmore reviewed Sep 1, 2018

View reviewed changes

Fixed logic error on eval of param

5f34955

abitmore reviewed Sep 3, 2018

View reviewed changes

abitmore mentioned this pull request Sep 3, 2018

Review subscription API #777

Closed

9 tasks

Add white space to keep you-know-who happy

f7d3747

jmjatlanta removed the 2a Discussion Needed Prompt for team to discuss at next stand up. label Sep 3, 2018

abitmore approved these changes Sep 3, 2018

View reviewed changes

abitmore merged commit 2997d02 into develop Sep 3, 2018

abitmore mentioned this pull request Sep 3, 2018

Re-add enable-subscribe-notify-all option after GUI issue fixed #752

Closed

TheTaconator mentioned this pull request Oct 16, 2018

Release Notes for BitShares Core 201810 #1381

Closed

jmjatlanta deleted the jmj_issue_752 branch November 12, 2018 13:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

jmjatlanta commented Jun 13, 2018 •

edited by abitmore

Loading

oxarbitrage left a comment

abitmore commented Jun 13, 2018

jmjatlanta commented Jun 13, 2018

cogutvalera left a comment

abitmore commented Aug 17, 2018

abitmore Aug 23, 2018

abitmore left a comment

abitmore Aug 27, 2018

jmjatlanta commented Sep 1, 2018 •

edited

Loading

clockworkgr commented Sep 1, 2018 •

edited

Loading

abitmore commented Sep 1, 2018

abitmore Sep 1, 2018

jmjatlanta Sep 1, 2018 •

edited

Loading

jmjatlanta commented Sep 1, 2018

abitmore Sep 3, 2018

jmjatlanta Sep 3, 2018

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

Revert commit b7ae96f as the bitshares/bitshares-ui#1338 is complete #1049

Conversation

jmjatlanta commented Jun 13, 2018 • edited by abitmore Loading

oxarbitrage left a comment

Choose a reason for hiding this comment

abitmore commented Jun 13, 2018

jmjatlanta commented Jun 13, 2018

cogutvalera left a comment

Choose a reason for hiding this comment

abitmore commented Aug 17, 2018

abitmore Aug 23, 2018

Choose a reason for hiding this comment

abitmore left a comment

Choose a reason for hiding this comment

abitmore Aug 27, 2018

Choose a reason for hiding this comment

jmjatlanta commented Sep 1, 2018 • edited Loading

clockworkgr commented Sep 1, 2018 • edited Loading

abitmore commented Sep 1, 2018

abitmore Sep 1, 2018

Choose a reason for hiding this comment

jmjatlanta Sep 1, 2018 • edited Loading

Choose a reason for hiding this comment

jmjatlanta commented Sep 1, 2018

abitmore Sep 3, 2018

Choose a reason for hiding this comment

jmjatlanta Sep 3, 2018

Choose a reason for hiding this comment

jmjatlanta commented Jun 13, 2018 •

edited by abitmore

Loading

jmjatlanta commented Sep 1, 2018 •

edited

Loading

clockworkgr commented Sep 1, 2018 •

edited

Loading

jmjatlanta Sep 1, 2018 •

edited

Loading