Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow increasing debt if still in margin call territory #672

Closed
abitmore opened this issue Feb 16, 2018 · 2 comments
Closed

Don't allow increasing debt if still in margin call territory #672

abitmore opened this issue Feb 16, 2018 · 2 comments

Comments

@abitmore
Copy link
Member

PR #655 introduces a new vulnerability that a call order in margin call territory can greatly increase debt while slightly increasing collateral ratio and still hangs there, which will make it harder to be filled, thus may increase possibility of black swan event and bring more risks to the pegging system.

I think we can fix this by not allowing increasing debt if the call order can not be filled immediately or get out of margin call territory.

I will draft a BSIP for this as well as PR #655 and its addressed issue (#583).

@pmconrad
Copy link
Contributor

Hm, valid point. Good catch.

Alternative solution: allow increase of debt and collateral if delta_collateral/delta_debt > feed*MCR.

@abitmore
Copy link
Member Author

abitmore commented Apr 8, 2018

Done with #827. Closing.

@abitmore abitmore closed this as completed Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants