Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change index of operation_history objects from simple_index to generic_index #403

Closed
abitmore opened this issue Sep 21, 2017 · 5 comments
Closed

Change index of operation_history objects from simple_index to generic_index #403

abitmore opened this issue Sep 21, 2017 · 5 comments
Assignees
@oxarbitrage
Milestone
201712 - Non-Cons...

Comments

@abitmore
Copy link
Member

abitmore commented Sep 21, 2017 •
edited
Loading

Simple indexes aren't good when objects need to be removed. Memory won't get freed, begin() doesn't work and etc. Related code is here and here. I'm not sure whether use_next_id() calls here and here will be affected.
@pmconrad
Copy link
Contributor

I agree.
simple_index uses a vector of pointers as backing store. While the memory for the objects is freed, the vector will grow forever. This is very inefficient, especially if it is sparsely populated.

@oxarbitrage
Copy link
Member

i can give a try to this index change this starting week if none of you guys are already working on. please let know.

@oxarbitrage oxarbitrage self-assigned this Sep 28, 2017
abitmore added a commit to abitmore/bitshares-core that referenced this issue Nov 7, 2017
@abitmore
Change operation_history to generic_index, bitshares#403
d404f53
@abitmore abitmore mentioned this issue Nov 7, 2017
Merged
@abitmore
Copy link
Member Author

abitmore commented Nov 7, 2017

See PR #464.

abitmore added a commit to abitmore/bitshares-core that referenced this issue Nov 7, 2017
@abitmore
Proper operation_history_obj initialization, bitshares#403
e8308e4
@oxarbitrage
Copy link
Member

thank you for making it, i had it under my TODO list but never found the time.

abitmore added a commit that referenced this issue Nov 8, 2017
@abitmore
Merge pull request #464 from abitmore/403-ophis-index-change
7cf7cd2 
Change operation_history to generic_index, #403
@abitmore
Copy link
Member Author

abitmore commented Nov 8, 2017

Merged to develop, closing.

@abitmore abitmore closed this as completed Nov 8, 2017
@abitmore abitmore added this to the Next Non-Consensus-Changing Release - 201712 milestone Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
None yet
Projects
None yet
Milestone
201712 - Non-Consensus-Changing Release
Development

No branches or pull requests
3 participants
@pmconrad @abitmore @oxarbitrage