Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding genesis does not work #1965

Closed
3 tasks
pmconrad opened this issue Sep 1, 2019 · 1 comment
Closed
3 tasks

Embedding genesis does not work #1965

pmconrad opened this issue Sep 1, 2019 · 1 comment
Assignees
@pmconrad
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 9a Tiny Effort estimation indicating TBD
Milestone
3.3.0 - Feature R...

Comments

@pmconrad
Copy link
Contributor

pmconrad commented Sep 1, 2019 •
edited
Loading

Build Error Description
The cmake setting -DGRAPHENE_EGENESIS_JSON=path/to/my-genesis.json is ignored.

Build Environment

  • Host OS: Linux
  • Source Branch/Tag: release
  • Boost Version: [e.g. 1.66]
  • C++ Compiler: gcc-7.4
  • CMake version: 3.10.2

Steps To Reproduce

  1. cmake -DGRAPHENE_EGENESIS_JSON=path/to/my-genesis.json .
  2. CMake output contains this line, showing it's ignoring the setting: -- egenesis: [...]/libraries/egenesis/genesis.json
  3. make
  4. Starting witness_node prints the default chain ID, node runs with mainnet genesis file.

Additional Information
Thanks @cedar-book for finding this bug!

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Provide build guidance
  • Create Bug Report
@pmconrad pmconrad added 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 9a Tiny Effort estimation indicating TBD labels Sep 1, 2019
@pmconrad pmconrad added this to the 3.3.0 - Feature Release milestone Sep 1, 2019
@pmconrad pmconrad self-assigned this Sep 1, 2019
pmconrad added a commit to pmconrad/bitshares-core that referenced this issue Sep 1, 2019
@pmconrad
Fix bitshares#1965
eb65c2b
@pmconrad pmconrad mentioned this issue Sep 1, 2019
Merged
pmconrad added a commit that referenced this issue Sep 2, 2019
@pmconrad
Merge pull request #1966 from pmconrad/1965_fix_GRAPHENE_EGENESIS_JSON
ff65d06 
Fix #1965
@pmconrad
Copy link
Contributor Author

pmconrad commented Sep 2, 2019

Fixed by #1966

@pmconrad pmconrad closed this as completed Sep 2, 2019
@MichelSantos MichelSantos mentioned this issue Sep 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmconrad pmconrad

Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Build Impact flag identifying the build process 9a Tiny Effort estimation indicating TBD
Projects
None yet
Milestone
3.3.0 - Feature Release
Development

No branches or pull requests
1 participant
@pmconrad