FIX Make Int8Params deepcopy-able #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires to implement the __deepcopy__ method in Int8Params. Moreover, there was an issue in the Linear8BitLT constructor that would assign instance attributes to the class, which is now fixed. Please review carefully that this does not impact existing code. Tests that I ran: - pytest tests/test_linear8bitlt.py - in PEFT: python -m pytest -m "single_gpu_tests and bitsandbytes" tests/test_gpu_examples.py - in PEFT: python -m pytest -m "single_gpu_tests and bitsandbytes" tests/test_common_gpu.py - in transformers: RUN_SLOW=1 python -m pytest tests/quantization/bnb -x
Titus-von-Koeller
merged commit 3c8c18a
into
bitsandbytes-foundation:main
19 checks passed
|
Very clean, thanks so much @BenjaminBossan, great work and very helpful! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires to implement the
__deepcopy__method inInt8Params. Moreover, there was an issue in theLinear8BitLTconstructor that would assign instance attributes to the class, which is now fixed.Please review carefully that this does not impact existing code.
Tests that I ran:
pytest tests/test_linear8bitlt.pypython -m pytest -m "single_gpu_tests and bitsandbytes" tests/test_gpu_examples.pypython -m pytest -m "single_gpu_tests and bitsandbytes" tests/test_common_gpu.pyRUN_SLOW=1 python -m pytest tests/quantization/bnb