Initialization #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
reviewed
Aug 29, 2018
bitrise.yml
Outdated
| set -ex | ||
| stepman audit --step-yml ./step.yml | ||
|
|
||
| share-this-step: |
There was a problem hiding this comment.
we do not need the share workflow here anymore
godrei
reviewed
Aug 29, 2018
bitrise.yml
Outdated
| app: | ||
| envs: | ||
| # if you want to share this step into a StepLib | ||
| - MY_STEPLIB_REPO_FORK_GIT_URL: $MY_STEPLIB_REPO_FORK_GIT_URL |
There was a problem hiding this comment.
we do not need the share related envs: MY_STEPLIB_REPO_FORK_GIT_URL & STEP_VERSION
godrei
reviewed
Aug 29, 2018
|
|
||
| # ---------------------------------------------------------------- | ||
| # --- workflows to Share this step into a Step Library | ||
| audit-this-step: |
There was a problem hiding this comment.
you can keep this for testing, just add as before workflow to the test wf
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| successful := true | ||
|
|
||
| log.Infof("Upload APKs") |
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| responseModel := &UploadURLRequest{} | ||
|
|
||
| err = json.Unmarshal(body, responseModel) |
There was a problem hiding this comment.
move this to the if statement
godrei
reviewed
Aug 29, 2018
main.go
Outdated
| failf("Failed to unmarshal response body, error: %s", err) | ||
| } | ||
|
|
||
| err = uploadFile(responseModel.AppURL, configs.ZipPath) |
There was a problem hiding this comment.
move this to the if statement
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| // parse environment variables | ||
| scanner = bufio.NewScanner(strings.NewReader(configs.EnvironmentVariables)) | ||
| envs := []*testing.EnvironmentVariable{} |
There was a problem hiding this comment.
var envs []*testing.EnvironmentVariable
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| responseModel := &toolresults.ListStepsResponse{} | ||
|
|
||
| err = json.Unmarshal(body, responseModel) |
There was a problem hiding this comment.
move this to the if statement
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| log.Infof("Test results:") | ||
| w := tabwriter.NewWriter(os.Stdout, 0, 0, 3, ' ', 0) | ||
| if _, err := fmt.Fprintln(w, "Model\tAPI Level\tLocale\tOrientation\tOutcome\t"); err != nil { |
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| responseModel := map[string]string{} | ||
|
|
||
| err = json.Unmarshal(body, &responseModel) |
godrei
reviewed
Aug 29, 2018
main.go
Outdated
|
|
||
| for fileName, fileURL := range responseModel { | ||
| err := downloadFile(fileURL, filepath.Join(tempDir, fileName)) | ||
| if err != nil { |
godrei
reviewed
Aug 29, 2018
main.go
Outdated
| } | ||
|
|
||
| _, err = io.Copy(out, resp.Body) | ||
| if err != nil { |
godrei
reviewed
Aug 29, 2018
| } | ||
| }() | ||
|
|
||
| _, err = ioutil.ReadAll(resp.Body) |
godrei
reviewed
Aug 29, 2018
step.yml
Outdated
| opts: | ||
| title: "Zip path" | ||
| summary: | | ||
| The path to the zip file which contains the folder Debug-iphoneos and PROJECT_NAME_iphoneosDEVELOPMENT_TARGET-arm64.xctestrun. |
There was a problem hiding this comment.
PROJECT_NAME_iphoneos_DEVELOPMENT_TARGET-
godrei
reviewed
Aug 29, 2018
step.yml
Outdated
| category: "Debug" | ||
| title: "Download files" | ||
| summary: | | ||
| If this input is set to `true` all files generated in the test run and the files you downloaded from the device (if you have set `directories_to_pull` input as well) will be downloaded. Otherwise, no any file will be downloaded. |
There was a problem hiding this comment.
generated in the test?
Otherwise, no any file?
godrei
reviewed
Aug 29, 2018
| summary: The token required to authenticate with the API. | ||
| description: | | ||
| The token required to authenticate with the API. | ||
| is_required: true |
There was a problem hiding this comment.
is_sensitive: true, also update other inputs
godrei
reviewed
Aug 29, 2018
| } | ||
|
|
||
| fmt.Println() | ||
| log.Infof("Start test") |
There was a problem hiding this comment.
would not it possible to separate the phases into separate functions?
godrei
requested changes
Aug 29, 2018
BirmacherAkos
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.