Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip inputIsFailIfOldValueNotFound logic #7

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Flip inputIsFailIfOldValueNotFound logic #7

merged 2 commits into from
Sep 21, 2021

Conversation

BonnetM
Copy link
Contributor

@BonnetM BonnetM commented Jan 23, 2020

Step fails if input is true and value not found

A quick fix for #6

Flip inputIsFailIfOldValueNotFound logic
1286d1c 
Step fails if input is true and value not found
@istx25 istx25 mentioned this pull request Feb 24, 2020
Closed
@istx25
Copy link

istx25 commented Feb 24, 2020

Hi @BonnetM @rcholley,

Thanks for filing this pull request, @BonnetM.

I am going to raise this with the tooling team internally. They will decide if the pull request will be merged and schedule this for the next release.

@Bence1001
Copy link
Contributor

Bence1001 commented Sep 21, 2021 •
edited
Loading

Hey @BonnetM! 👋

Thanks for the fix, and sorry for taking so long with our review! I'm going to merge this and add some tests in a separate PR.
The next major version will contain the fix.

@Bence1001 Bence1001 merged commit d2b3a2f into bitrise-steplib:master Sep 21, 2021
@Bence1001 Bence1001 mentioned this pull request Sep 21, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bence1001 Bence1001 Bence1001 approved these changes

@rcholley rcholley rcholley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BonnetM @istx25 @Bence1001 @rcholley