Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

[WIP] Xcode 13 support #84

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[WIP] Xcode 13 support #84

wants to merge 9 commits into from

Conversation

shams-ahmed
Copy link
Contributor

@shams-ahmed shams-ahmed commented Aug 10, 2021

Proposed changes:

  • Xcode 13 support
  • Build SDK using iOS 15
  • Removed lots of warnings and errors
  • Renamed Network to HTTPNetwork
  • Use Trace class directly instead of looking it up at runtime for Swift loading
  • Added @available(iOSApplicationExtension, unavailable) to make sure Trace is only linked for iOS

Known issues (as of Xcode 13 beta 5)

  • Building project with armv7 fails with a network issue. Known issue reported to Apple
/Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS15.0.sdk/System/Library/Frameworks/Combine.framework/Modules/Combine.swiftmodule/armv7-apple-ios.swiftinterface:57:59: 'AnyCancellable' is only available in iOS 13.0 or newer
  • Disabled NWPathMonitor logic in Connectivity class
  • Trace naming conflicts with the following message:
    public class 'Trace.Trace' shadows module 'Trace', which may cause failures when importing 'Trace' or its clients in some configurations; please rename either the class 'Trace.Trace' or the module 'Trace', or see https://bugs.swift.org/browse/SR-14195 for workarounds

Pre-requisites:

  • Reviewed code before asking reviewer (Look at Files Changed below instead of Xcode).
  • Reviewed code format follows the style guide where possible.
  • Added tests where possible (*compulsory for business logic and new classes).

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
7.4% 7.4% Duplication

@shams-ahmed shams-ahmed changed the title [WIP] Xcode13 support [WIP] Xcode 13 support Aug 23, 2021
@shams-ahmed shams-ahmed self-assigned this Aug 24, 2021
@shams-ahmed shams-ahmed added the enhancement New feature or request label Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant