Send payload to stdin #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lpusok
reviewed
Mar 13, 2020
plugins/run.go
Outdated
| @@ -132,6 +132,12 @@ func runPlugin(plugin Plugin, args []string, pluginInput PluginInput) error { | |||
| return err | |||
| } | |||
|
|
|||
| var payload []byte = nil | |||
There was a problem hiding this comment.
Suggested change
| var payload []byte = nil | |
| var payload []byte |
There was a problem hiding this comment.
lpusok
previously approved these changes
Mar 13, 2020
godrei
requested changes
Mar 16, 2020
plugins/run.go
Outdated
| @@ -132,6 +132,12 @@ func runPlugin(plugin Plugin, args []string, pluginInput PluginInput) error { | |||
| return err | |||
| } | |||
|
|
|||
| var payload []byte | |||
There was a problem hiding this comment.
instead, I suggest to modify the runPlugin method -> func runPlugin(plugin Plugin, args []string, envs map[string]string, input []byte) error.
current pluginInput contains configuration for the plugin run -> env
input would be the data to be sent on the plugin command's stdin
it would make clear what input threated how, this change will need you to modify RunPluginByEvent as well, to distinguish plugin configs (envs) and the payload (input).
There was a problem hiding this comment.
I am not sure if we should differentiate between envs and stdin here. We should discuss this
godrei
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send payload to stdin instead of providing it as an environmental variable to overcome the 20kB limit