add support for new version lock #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rise into TOOL-387-new-version-lock
trapacska
previously approved these changes
Jan 21, 2020
lpusok
reviewed
Jan 22, 2020
| stepIDData models.StepIDData | ||
| wantVersion string | ||
| wantErr bool | ||
| }{ |
There was a problem hiding this comment.
Can you add a test case for "" and x.x.x (even if not supported, just as a reference)
lpusok
previously approved these changes
Jan 23, 2020
…gin (over the 20 Kb limit), reverting original functionality.
lpusok
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepman PR needs to be merged first to introduce StepInfoModel.OriginalVersion and dep update needs to be run to pull the latest stepman packages.