Add missing graph pipeline validation #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
reviewed
Oct 30, 2024
models/models.go
Outdated
|
|
||
| allowedValues := []string{string(GraphPipelineAlwaysRunModeOff), string(GraphPipelineAlwaysRunModeWorkflow)} | ||
| if !slices.Contains(allowedValues, value) { | ||
| return fmt.Errorf("%s is not a valid should always run value", value) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("%s is not a valid should always run value", value) | |
| return fmt.Errorf("%s is not a valid should_always_run value", value) |
There was a problem hiding this comment.
Maybe also print the allowed values too? Given that it's already there in a slice.
There was a problem hiding this comment.
Good ideas. I have updated the code.
ofalvai
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
There were a couple of graph pipeline validations which were not yet added to the CLI.