Check if step uses locked version and update Steplib if so. (#704)

* Check if step uses locked version and update Steplib if so.

* Clean up version parsing.

* dep update

* Fixing stepman test case, failed due to testing a stepman version installed, not the current one.

cli/run_util.go

@@ -523,14 +523,25 @@ func activateStepLibStep(stepIDData models.StepIDData, destination, stepYMLCopyP
 	log.Debugf("[BITRISE_CLI] - Steplib (%s) step (id:%s) (version:%s) found, activating step", stepIDData.SteplibSource, stepIDData.IDorURI, stepIDData.Version)
 	if err := stepman.SetupLibrary(stepIDData.SteplibSource); err != nil {
 		return stepmanModels.StepInfoModel{}, false, err
+	}
 
+	versionConstraint, err := stepmanModels.ParseRequiredVersion(stepIDData.Version)
+	if err != nil {
+		return stepmanModels.StepInfoModel{}, false,
+			fmt.Errorf("activating step (%s) from source (%s) failed, invalid version specified: %s", stepIDData.IDorURI, stepIDData.SteplibSource, err)
+	}
+	if versionConstraint.VersionLockType == stepmanModels.InvalidVersionConstraint {
+		return stepmanModels.StepInfoModel{}, false,
+			fmt.Errorf("activating step (%s) from source (%s) failed, version constraint is invalid", stepIDData.IDorURI, stepIDData.SteplibSource)
 	}
 
-	isLatestVersionOfStep := (stepIDData.Version == "")
-	if isLatestVersionOfStep && !isStepLibUpdated {
+	isStepLibUpdateNeeded := (versionConstraint.VersionLockType == stepmanModels.Latest) ||
+		(versionConstraint.VersionLockType == stepmanModels.MinorLocked) ||
+		(versionConstraint.VersionLockType == stepmanModels.MajorLocked)
+	if !isStepLibUpdated && isStepLibUpdateNeeded {
 		log.Infof("Step uses latest version -- Updating StepLib ...")
 		if _, err := stepman.UpdateLibrary(stepIDData.SteplibSource); err != nil {
-			log.Warnf("Step uses latest version, but failed to update StepLib, err: %s", err)
+			log.Warnf("Step version constraint is latest or version locked, but failed to update StepLib, err: %s", err)
 		} else {
 			didStepLibUpdate = true
 		}

tools/tools_test.go

@@ -83,8 +83,8 @@ func TestStepmanJSONStepLibStepInfo(t *testing.T) {
 	require.NotEqual(t, "", outStr)
 
 	// Invalid params -- Err should empty, output filled
-	outStr, err = StepmanJSONStepLibStepInfo("https://github.com/bitrise-io/bitrise-steplib", "script", "2")
-	require.NotEqual(t, nil, err)
+	outStr, err = StepmanJSONStepLibStepInfo("https://github.com/bitrise-io/bitrise-steplib", "script", "2.x")
+	require.Error(t, err)
 	require.Equal(t, "", outStr)
 }