Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xcode parsing lib #239

Merged
merged 15 commits into from
Feb 23, 2022
Merged

Conversation

lpusok
Copy link
Contributor

@lpusok lpusok commented Feb 16, 2022

Changes

  • Updated iOS Scanner to use absolute paths everywhere, in preparation of the updated xcodeproj package. This required updating a few Cocoapods parsing Ruby scripts.
  • Fixed/worked around a problem that only top-level (Pod target) projects were parsed from Podfiles. Now using the first project, disregarding which target is it in.
# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'Sample' do
  # Comment the next line if you don't want to use dynamic frameworks
  use_frameworks!
  project 'Sample/Sample.xcodeproj'
  # Pods for Sample
  pod 'Alamofire', '~> 5.5'
end
  • Added a container interface which is implemented by projectContainer (.xcodeproj), workspaceContainer (.xcworkspace); and podWorkpace (an .xcworkspace where the actual workspace is not present, only the project files).

Resolves: https://bitrise.atlassian.net/browse/STEP-1804

@lpusok lpusok changed the title Updaet Xcode parsing lib Update Xcode parsing lib Feb 16, 2022
@lpusok lpusok force-pushed the STEP-1804-xcode-project-parsing-lib-migration branch from e88d1cb to 5cb1fb7 Compare February 21, 2022 16:19
go.mod Outdated Show resolved Hide resolved
scanners/ios/podfile.go Outdated Show resolved Hide resolved
if target == "Pods" {
return project, nil
}
// Return the first custom project
Copy link
Contributor Author

@lpusok lpusok Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed/worked around a problem that only top-level (Pod target) projects were parsed from Podfiles. Now using the first project, disregarding which target is it in. For example, the project is under Sample target here. (It would be Pod if it was before the Sample target declaration.)

# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'Sample' do
  # Comment the next line if you don't want to use dynamic frameworks
  use_frameworks!
  project 'Sample/Sample.xcodeproj'
  # Pods for Sample
  pod 'Alamofire', '~> 5.5'
end

@lpusok lpusok marked this pull request as ready for review February 22, 2022 08:21
scanners/ios/icon.go Outdated Show resolved Hide resolved
scanners/ios/podfile.go Outdated Show resolved Hide resolved
scanners/ios/podfile.go Outdated Show resolved Hide resolved
scanners/ios/project.go Outdated Show resolved Hide resolved
scanners/ios/project.go Outdated Show resolved Hide resolved
scanners/ios/project.go Outdated Show resolved Hide resolved
@lpusok lpusok requested a review from godrei February 22, 2022 14:52
@lpusok lpusok merged commit 37dca45 into master Feb 23, 2022
@lpusok lpusok deleted the STEP-1804-xcode-project-parsing-lib-migration branch February 23, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants