Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for react-native workflow duplicate Steps #234

Merged
merged 9 commits into from
Feb 14, 2022

Conversation

lpusok
Copy link
Contributor

@lpusok lpusok commented Feb 11, 2022

Checklist

  • I've read and followed the Contribution Guidelines
  • [/] step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

In case of multiple iOS schemes being present for react-native, duplicate xcode-archive and deploy-to-bitrise-io Steps were generated.
A previous unmerged attampt was #228.

Resolves: https://bitrise.atlassian.net/browse/STEP-1742

Changes

  • Added iOS config descriptors (missing scheme, podfile) to react-native scanner.
  • Added option to select between multiple react-native projects. For Expo this is not supported.

@lpusok lpusok changed the title Redo ios react-native options generation Fix for react-native workflow duplicate Steps Feb 11, 2022
@lpusok lpusok marked this pull request as ready for review February 11, 2022 15:34
Multiple plrojects working

Use absolute path, fixes for multiple package.jsons

Fix missing config

Fix for native projects relative path

Fix for yarn lock
_tests/integration/reactnative_test.go Show resolved Hide resolved
scanners/reactnative/expo.go Outdated Show resolved Hide resolved
scanners/reactnative/plain.go Outdated Show resolved Hide resolved
scanners/reactnative/reactnative.go Outdated Show resolved Hide resolved
@lpusok lpusok requested a review from godrei February 14, 2022 14:18
@lpusok lpusok merged commit 72be2c6 into master Feb 14, 2022
@lpusok lpusok deleted the STEP-1742-react-native-dulicate-steps2 branch February 14, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants