Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 1743 - Update Expo deploy workflow #229

Merged
merged 10 commits into from
Feb 10, 2022
Merged

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Feb 9, 2022

Context

Building an Expo-based React Native project has changed a lot since we last time updated the default workflows:
Expo eject is not needed for building the project, running builds on Expo Application Services (EAS) is the recommended way.

Other than that, we apply general improvements to the default workflows:

  • Add Activate SSH key (RSA private key) only if needed
  • Remove the dummy Script Step
  • Improve the workflow descriptions

Changes

Non-functional changes:

  • Move Expo related Steps' Input configuration to the steps package, so that it is the steps package responsibility to know what input key configures the given input.

YarnStepListItem(inputs ...envmanModels.EnvironmentItemModel) -> YarnStepListItem(command, workdir string)

  • Created a getTestSteps function to unify the way we add test steps to automatic and manual configs.

Investigation details

I used the Expo docs for reference.

Decisions

@godrei godrei marked this pull request as ready for review February 9, 2022 13:56
@lpusok
Copy link
Contributor

lpusok commented Feb 9, 2022

@godrei Is EAS working for bare Expo workflows also?

@godrei
Copy link
Contributor Author

godrei commented Feb 9, 2022

@lpusok yes, you can find it in the Expo docs: https://docs.expo.dev/bare/exploring-bare-workflow/#releasing-to-the-apple-app-store-and
also, you can find a working sample in our Expo account.

@godrei godrei merged commit 656d93f into master Feb 10, 2022
@godrei godrei deleted the STEP-1743-expo-deploy branch February 10, 2022 09:56
godrei added a commit that referenced this pull request Feb 10, 2022
godrei added a commit that referenced this pull request Feb 10, 2022
@godrei godrei restored the STEP-1743-expo-deploy branch February 10, 2022 14:34
@godrei godrei mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants