-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step 1743 - Update Expo deploy workflow #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shams-ahmed
approved these changes
Feb 9, 2022
@godrei Is EAS working for bare Expo workflows also? |
@lpusok yes, you can find it in the Expo docs: https://docs.expo.dev/bare/exploring-bare-workflow/#releasing-to-the-apple-app-store-and |
lpusok
approved these changes
Feb 10, 2022
godrei
added a commit
that referenced
this pull request
Feb 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Building an Expo-based React Native project has changed a lot since we last time updated the default workflows:
Expo eject is not needed for building the project, running builds on Expo Application Services (EAS) is the recommended way.
Other than that, we apply general improvements to the default workflows:
Activate SSH key (RSA private key)
only if neededScript
StepChanges
deploy
workflow.Non-functional changes:
steps
package, so that it is thesteps
package responsibility to know what input key configures the given input.YarnStepListItem(inputs ...envmanModels.EnvironmentItemModel)
->YarnStepListItem(command, workdir string)
getTestSteps
function to unify the way we add test steps to automatic and manual configs.Investigation details
I used the Expo docs for reference.
Decisions