Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

Repair reconnecting #89

Merged
merged 5 commits into from
Feb 2, 2018
Merged

Repair reconnecting #89

merged 5 commits into from
Feb 2, 2018

Conversation

nodarret
Copy link
Contributor

@nodarret nodarret commented Feb 2, 2018

  • repair reconnecting
  • logging with exchange name instead NettyStreamingService
  • removed WebSocketClientCompressionHandler.INSTANCE handler

@dozd dozd merged commit b6ae150 into bitrich-info:develop Feb 2, 2018
@hlbkin
Copy link

hlbkin commented Feb 2, 2018

Should we consider blockingAwait logic like here firegnome@5d09ad5?

I mean if we insert .blockingAwait after connect. in line 305?

@nodarret
Copy link
Contributor Author

nodarret commented Feb 2, 2018

I think timeout execption should be from netty, not completable (possible memory leaks?). Also every blocking mechanism in async programing is not recommended - both netty and rxJava are async. Better way is register action on event. In my case retryWhen retry with delay when Exception is thrown and doOnComplete resubscribes if completable completes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants