Add support for page cache #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdanpetrea
force-pushed
the
page-cache-redis
branch
5 times, most recently
from
96e316c
to
d0831c9
Compare
AMecea
reviewed
Jun 17, 2020
bogdanpetrea
force-pushed
the
page-cache-redis
branch
from
d0831c9
to
0aee311
Compare
AMecea
suggested changes
Jun 18, 2020
php/docker/templates/nginx-vhost-conf.d/75-page-cache-locations.conf
Outdated
Show resolved
Hide resolved
bogdanpetrea
force-pushed
the
page-cache-redis
branch
3 times, most recently
from
bd19bf6
to
429c0ec
Compare
vtemian
suggested changes
Jun 23, 2020
| } | ||
|
|
||
| # Don't cache uris containing the following segments | ||
| if ($request_uri ~* "/wp-admin/|/xmlrpc.php|wp-.*.php|/feed/|index.php|sitemap(_index)?.xml") { |
There was a problem hiding this comment.
It should work for multisites, right?
There was a problem hiding this comment.
It needs to be tested in that scenario to know for sure.
bogdanpetrea
force-pushed
the
page-cache-redis
branch
2 times, most recently
from
e570753
to
e69c116
Compare
bogdanpetrea
changed the title
AMecea
reviewed
Jun 25, 2020
bogdanpetrea
force-pushed
the
page-cache-redis
branch
2 times, most recently
from
cd67461
to
6a3ab4f
Compare
bogdanpetrea
force-pushed
the
page-cache-redis
branch
from
6a3ab4f
to
fcf2d49
Compare
AMecea
suggested changes
Jul 14, 2020
php/docker/templates/nginx-vhost-conf.d/page-cache.d/10-index.conf
Outdated
Show resolved
Hide resolved
bogdanpetrea
force-pushed
the
page-cache-redis
branch
from
fcf2d49
to
e7ab358
Compare
AMecea
suggested changes
Jul 17, 2020
php/docker/templates/nginx-vhost-conf.d/75-page-cache-locations.conf
Outdated
Show resolved
Hide resolved
|
|
||
| redis2_query set $key $echo_request_body; | ||
| redis2_query expire $key $exptime; | ||
| redis2_pass {{ default "localhost:6379" .Env.STACK_PAGE_CACHE_REDIS_HOST_PATH }}; |
There was a problem hiding this comment.
Suggested change
| redis2_pass {{ default "localhost:6379" .Env.STACK_PAGE_CACHE_REDIS_HOST_PATH }}; | |
| redis2_pass {{ default "localhost" .Env.STACK_PAGE_CACHE_REDIS_HOST }}:{{ default "6379" .Env.STACK_PAGE_CACHE_REDIS_PORT }}; |
And add Redis password:
{{ with .Env.STACK_PAGE_CACHE_REDIS_PASSWORD }}
redis2_query auth {{ . }}
{{- end }}There was a problem hiding this comment.
We can work on this in a later PR, since it's not so straightforward. See:
openresty/srcache-nginx-module#60
openresty/srcache-nginx-module#41
AMecea
suggested changes
Jul 17, 2020
php/docker/templates/nginx-vhost-conf.d/page-cache.d/10-index.conf
Outdated
Show resolved
Hide resolved
bogdanpetrea
force-pushed
the
page-cache-redis
branch
from
e7ab358
to
4fd6851
Compare
AMecea
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.