Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with @demo tag after updating to 0.5.2 #287

Closed
kylegifford opened this issue Jun 18, 2018 · 10 comments · Fixed by #293
Closed

Error with @demo tag after updating to 0.5.2 #287

kylegifford opened this issue Jun 18, 2018 · 10 comments · Fixed by #293

Comments

@kylegifford
Copy link
Contributor

kylegifford commented Jun 18, 2018

I upgraded an existing DocJS site from 0.4.4 to 0.5.2. On a page with the @demo tag, I get the following error. This does not happen on 0.4.4.

screenshot 2018-06-18 16 21 13
screenshot 2018-06-18 16 44 28

@tracer99
Copy link

I was looking at this myself as well. If you check out the project, two tests are failing

  1. documentjs/lib/generators/html
    can push out dev mode static:
  1. documentjs/lib/generators/html
    "after each" hook for "body is rendered as a mustache template prior to markdown":

Don't know if related.

@Eruedraith
Copy link

I'm running into the same issue, does anyone have a fix on this yet?

@tracer99
Copy link

tracer99 commented Jul 5, 2018

@Eruedraith only a workaround. We're putting int @iframe tags for now until this gets fixed.

@Eruedraith
Copy link

Thanks for the quick response @tracer99
You are putting this into the stylesheet?
@iframe @demo /demos/typography.html

@tracer99
Copy link

tracer99 commented Jul 5, 2018

not exactly
@iframe /demos/typography.html

then at some point, if it gets fixed, just do a search and replace for @iframe and replace with @demo

@Eruedraith
Copy link

Eruedraith commented Jul 5, 2018

Okay that's what I figured, thank you.
So for the DocumentCSS portion, there won't be any tabs for now then?

Thanks for the patience, sorry this is the first time working with Documentjs.

@tracer99
Copy link

tracer99 commented Jul 5, 2018

Yeah, not ideal, but it works.
For small global styles, we're adding the following above the @iframe tag

* ```html
* <button class='largeBtn'></button>
* ```

Where the HTML is cut and paste from the demo.

@Eruedraith
Copy link

Thanks so much @tracer99! I appreciate the workaround.
I'm looking forward to trying out the @demo when it's fixed. :)

@johnnylord
Copy link

It has been awhile : (. I'm still waiting for the bug fixed.

m-mujica added a commit that referenced this issue Jan 9, 2019
Why?
The previous release of documentjs upgrade to [email protected] but
it did not account for the fact that the DemoFrame control was
instantiated with a jquery element which is no longer natively supported
in 3.x; this cause can-event to try to call addEventListener on a
jquery object which threw an error.

This is fixed by:
Make sure the control is instatiated with an HtmlElement instead of
a jquery-wrapped element.

Closes #287
@m-mujica
Copy link
Contributor

m-mujica commented Jan 11, 2019

hey guys sorry for the looong delay to gets this fixed. I just published 0.5.5 and it should take care of this error. Please let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants