-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with @demo tag after updating to 0.5.2 #287
Comments
I was looking at this myself as well. If you check out the project, two tests are failing
Don't know if related. |
I'm running into the same issue, does anyone have a fix on this yet? |
@Eruedraith only a workaround. We're putting int |
Thanks for the quick response @tracer99 |
not exactly then at some point, if it gets fixed, just do a search and replace for |
Okay that's what I figured, thank you. Thanks for the patience, sorry this is the first time working with Documentjs. |
Yeah, not ideal, but it works.
Where the HTML is cut and paste from the demo. |
Thanks so much @tracer99! I appreciate the workaround. |
It has been awhile : (. I'm still waiting for the bug fixed. |
Why? The previous release of documentjs upgrade to [email protected] but it did not account for the fact that the DemoFrame control was instantiated with a jquery element which is no longer natively supported in 3.x; this cause can-event to try to call addEventListener on a jquery object which threw an error. This is fixed by: Make sure the control is instatiated with an HtmlElement instead of a jquery-wrapped element. Closes #287
hey guys sorry for the looong delay to gets this fixed. I just published 0.5.5 and it should take care of this error. Please let me know if it works for you. |
I upgraded an existing DocJS site from 0.4.4 to 0.5.2. On a page with the
@demo
tag, I get the following error. This does not happen on 0.4.4.The text was updated successfully, but these errors were encountered: