Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/openldap] DOCS: Add instructions for verifying that the service is working #76871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bitnami/openldap] DOCS: Add instructions for verifying that the service is working #76871

wants to merge 1 commit into from

Conversation

excavator-matt
Copy link

Resolves #76862 . This however implies that the option LDAP_ROOT doesn't do anything. Another finding is that the referenced option LDAP_ADMIN_DN is undocumented in this README.

@github-actions github-actions bot added openldap triage Triage is needed labels Feb 4, 2025
@github-actions github-actions bot requested a review from carrodher February 4, 2025 14:40
@excavator-matt
Copy link
Author

And indeed neither does LDAP_ADMIN_PASSWORD or LDAP_USERS or am I doing something wrong?

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Feb 4, 2025
@github-actions github-actions bot removed the triage Triage is needed label Feb 4, 2025
@github-actions github-actions bot removed the request for review from carrodher February 4, 2025 16:59
@github-actions github-actions bot requested a review from gongomgra February 4, 2025 16:59
@gongomgra
Copy link
Contributor

Hi @excavator-matt,

Thanks for your contribution! You can find the LDAP_ADMIN_PASSWORD and LDAP_USERS definitions under the configuration section, but it is true the LDAP_ADMIN_DN variable is not there. Would you mind to add it?

gongomgra
gongomgra requested changes Feb 11, 2025
View reviewed changes
bitnami/openldap/README.md
@@ -170,6 +170,12 @@ Launch the containers using:
docker-compose up -d
```

Verify that LDAP service is accessible with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a ### prefix to this line to create a new section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongomgra gongomgra gongomgra requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@gongomgra gongomgra

Labels
in-progress openldap verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/openldap] (Documentation Request) Add debug instructions to example setup
3 participants
@excavator-matt @gongomgra @carrodher