[bitnami/mariadb] Don't overwrite existing secrets #9267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't overwrite already generated secret values on chart upgrade Issue #7403 (#7403) Signed-off-by: Paul Miu <[email protected]>
Don't overwrite already generated secret values on chart upgrade Issue #7403 (#7403) Common chart version has to be bumped. Signed-off-by: Paul Miu <[email protected]>
|
Thanks for creating this PR. Please, note it is needed to sign the commits. Your signature certifies that you wrote the patch or otherwise have the right to contribute the material. You can find more info about this topic, in the “Sign your work” section from the contributing guidelines. In the same way please note it's needed to create separate PRs per Helm chart, in this case you're modifying bitnami/common and bitnami/mariadb in a single PR |
|
@carrodher Ok sure, I'll separate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Don't overwrite already generated secret values on mariadb chart upgrade
Benefits
MariaDB doesn't break on chart upgrade.
Possible drawbacks
None.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.