Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq-cluster-operator] Specify default image pull secrets for the operator #8658

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Jan 13, 2022

Signed-off-by: juan131 [email protected]

Description of the change

This PR ensure the default image pull secrets information is passed to the operator using the DEFAULT_IMAGE_PULL_SECRETS environment variable.

Benefits

Possible drawbacks

None

Applicable issues

N/A

Additional information

Support for DEFAULT_IMAGE_PULL_SECRETS environment variable was recently added at rabbitmq/cluster-operator#926

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Title of the PR starts with chart name (e.g. [bitnami/<name_of_the_chart>])

@juan131 juan131 requested a review from javsalgar January 13, 2022 16:26
Copy link
Contributor

@javsalgar javsalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juan131 added 2 commits January 17, 2022 13:22
@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/rabbitmq-cluster-operator:1.11.0-scratch-r0"
  • "docker.io/bitnami/rabbitmq:3.8.27-debian-10-r6"
  • "docker.io/bitnami/rmq-default-credential-updater:1.0.1-scratch-r0"
  • "docker.io/bitnami/rmq-messaging-topology-operator:1.2.1-scratch-r0"

@bitnami-bot bitnami-bot merged commit cf6c0a3 into bitnami:master Jan 17, 2022
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching bitnami/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

@juan131 juan131 deleted the rmqco-secrets branch January 17, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants