[bitnami/external-dns] External-DNS Chart Broken with 7.3.3 due to removal of protected CRD group annotation #25967
Comments
pinkfloydx33
added
the
tech-issues
|
Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here. Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance. |
|
@carrodher I wouldn't know where to begin as the original change was made by some form of automation, which tells me that it too would need to be fixed. I also unfortunately need approval from my company before contributing, even to tools we use, and that would likely take more time than others broken by this change would appreciate. |
|
I have added the annotation to the pull request on the original external-dns project, I believe this is where the Bitnami automation gets its information from so if this gets approved hopefully the next release will contain it again? |
|
This has been fixed now with kubernetes-sigs/external-dns@f46676f I don't know the next steps though, I suppose a release needs to be done and then the bitnami chart updated to refer to the new release? |
|
I think the release of such updates is automated, not sure how they are triggered but I expect that it will come within a reasonable time. |
|
Our automation looks for new releases at https://github.com/kubernetes-incubator/external-dns. When a new release is cut there, our automated test & release process is triggered. As part of that process, the upstream CRDs are compared and the ones in the Bitnami chart are updated to match the upstream, i.e 375ee3b |
|
Still broken in 7.5.0 |
|
external-dns hasn't issued a new release yet so there's nothing for the new chart to go off of |
|
So... there's a fix? a workaround? if not, what version of the chart should i use? i tried the 7.5.2 but it didn't work :( |
|
@raiomarco Since the problem seems to have occurred starting with chart version 7.3.3, v7.3.2 should be the last stable version for now. We are still waiting for a new release in https://github.com/kubernetes-sigs/external-dns to include the fix. |
|
@cheinema Unless I'm missing something, the v0.14.2 release appears to have the fix. Is there anything else that needs to be done before merging the fix into the chart? |
You're looking at the external dns helm chart managed by external dns. This is not the source of crds for the bitnami chart. |
|
@rouke-broersma I knew I was missing something! Thanks. |
|
so seems crd cannot be updated manually, as there is ci pipeline which allows only bitnami bot to update crd. and there is no release from external-dns side which would include api-approved annotation. |
|
This chart is effectively broken for now... Does anyone have a way to workaround it or are we SOL for now? |
I think you could simply deploy the required resources yourself (updated crd, clusterRole on crd, clusterRoleBinding to serviceaccount from chart): https://github.com/search?q=repo%3Abitnami%2Fcharts%20path%3A%2F%5Ebitnami%5C%2Fexternal-dns%5C%2Ftemplates%5C%2F%2F%20.Values.crd.create&type=code That should be sufficient until upstream releases a new version. |
|
Ok thanks. We use Flux for management, I'm sure theres a way to do that, just haven't looked into it yet. Hopefully the upstream fixes it soon... |
|
Still broken with 7.5.7 |
|
@hawkesn the chart relies on external-dns coming out with another release which they haven't done in a month: https://github.com/kubernetes-sigs/external-dns/releases The next time external-dns release, it will have the fix, which will then get embedded in this chart. |
|
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
|
Commenting to keep this issue open |
* Update crd.yaml CRD doesn't work, this solving the problem ) * chore(CRD): Disable auto-update due to #25967 Signed-off-by: Fran Mulero <[email protected]> --------- Signed-off-by: Aleksei Pashkin <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Carlos Rodríguez Hernández <[email protected]> Signed-off-by: Fran Mulero <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: juan131 <[email protected]> Co-authored-by: Fran Mulero <[email protected]>
|
Looks like we may have a fix. Anyone roll out >= 8.3.5 in production yet? :) |
|
I updated without issues |
|
Thanks for letting us know! Can we close this issue then? |
|
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
|
@javsalgar I think we need to revert the change once the upstream chart has been released? |
|
Correct, when upstream releases, we can re-enable it. |
|
@javsalgar it is time. :) A new release was dropped yesterday and appears to have the fix: https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.15.0
|
|
Thanks for letting us know! I created a PR ⏫ |
|
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
|
Commenting so this issue doesn't fall stale. I think we are just waiting on #29266 to get merged. |
|
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
|
Still a work in progress. Hasn't been merged it: #29266 |
|
This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback. |
|
Anti stale post. Still waiting on #29266 |
Name and Version
bitnami/external-dns
What architecture are you using?
None
What steps will reproduce the bug?
Attempt to upgrade or install the external-dns chart at version 7.3.3. In our case, an automated upgrade via Flux has started spamming alerts across all of our environments where minor/patch upgrades are automatically performed.
What is the expected behavior?
Helm chart upgrades/installs
What do you see instead?
Installation fails with:
Additional information
This is because the automated upgrade has removed the protected annotation on the CRDs:
This annotation is required on CRDs if the group is
k8s.io,kubernetes.io, or ends with.k8s.io,.kubernetes.iowhich is applicable here because the CRD group isapiextensions.k8s.io.This change needs to be reverted or else the chart is unusable.
The text was updated successfully, but these errors were encountered: