Remove top level ui css class
#675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/scss/_ads.scss # src/scss/bitmovinplayer-ui.scss
stonko1994
force-pushed
the
feature/revert-css-nesting
branch
from
196e6c6 to
3ef2e61
Compare
stonko1994
commented
Jan 14, 2025
There was a problem hiding this comment.
Review this file with Hide Whitespaces enabled.
felix-hoc
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we started working on the new UI design, we introduced it as a new skin. However, this idea was discarded, and we want to make it the only UI design.
To enable the skinning feature, we added a top-level CSS class that wrapped everything. This is no longer needed. To keep breaking changes in CSS low, we can now remove this top level CSS class again to keep the old CSS selector compatibility.