build the structure of the new mobile ui with the old ui components #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitmovin-kenny
requested changes
Jul 12, 2024
src/ts/uifactory.ts
Outdated
Comment on lines
550
to
551
| //TODO: make a Share button | ||
| //new PictureInPictureToggleButton(), probably not needed in mobile version |
There was a problem hiding this comment.
Since this won't come back i guess you can just remove it.
src/ts/uifactory.ts
Outdated
| ], | ||
| }), | ||
| settingsPanel, | ||
| new Watermark(), |
There was a problem hiding this comment.
I don't think this should be in the final version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the layout of the new mobile UI version was build using the old/existing components(with old icons etc.)
Checklist (for PR submitter and reviewers)
CHANGELOGentry