Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased icon size and text size for accounts list #813

Merged
merged 3 commits into from
May 27, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented May 27, 2024

The PR should be in Draft state during development. As soon as it's finished, it should be marked as Ready for review and a reviewer should be chosen.

See also: Writing A Great Pull Request Description

Purpose

See #809. Increases the icon and text size of the accounts list items.

image

Short description

  • Increased icon size from 32dp to 48dp
  • Increased text style from bodyLarge to titleLarge.

Note

We might need to consider setting some text overflow if we don't want the title to take multiple lines.

image

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label May 27, 2024
@ArnyminerZ ArnyminerZ self-assigned this May 27, 2024
@ArnyminerZ ArnyminerZ linked an issue May 27, 2024 that may be closed by this pull request
2 tasks
@ArnyminerZ ArnyminerZ requested a review from rfc2822 May 27, 2024 09:12
@ArnyminerZ ArnyminerZ marked this pull request as ready for review May 27, 2024 09:12
@rfc2822
Copy link
Member

rfc2822 commented May 27, 2024

Had it like that before, guess it's too large for @devvv4ever. Will have a look with @devvv4ever

@rfc2822 rfc2822 requested review from devvv4ever and removed request for rfc2822 May 27, 2024 12:57
@rfc2822 rfc2822 self-assigned this May 27, 2024
@rfc2822 rfc2822 merged commit d722197 into main-ose May 27, 2024
1 check passed
@rfc2822 rfc2822 deleted the 809-ui-larger-text-for-accounts-overview branch May 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Larger text for accounts overview
2 participants