Add isEmpty util #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigan-abd
reviewed
Oct 9, 2023
| assert.strictEqual(isEmpty({ length: '0' }), false) | ||
| }) | ||
|
|
||
| it('should return true for negative lengths as array-like', () => { |
There was a problem hiding this comment.
should we add also tests for class instances? e.g. class Foo {}; const obj = new Foo()...
There was a problem hiding this comment.
no need as class is syntactic sugar for prototypes
but I can add it for better readability of the tests
would you like?
There was a problem hiding this comment.
yes please, let's include them for better long term support
vigan-abd
approved these changes
Oct 9, 2023
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
isEmptyutil, it checks if value is an empty object, collection, map, or setNote: